Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit CLI check for commands like rabbitmq-queues grow #8007

Closed
Zerpet opened this issue Apr 26, 2023 · 0 comments · Fixed by #8080
Closed

Add explicit CLI check for commands like rabbitmq-queues grow #8007

Zerpet opened this issue Apr 26, 2023 · 0 comments · Fixed by #8080
Assignees
@michaelklishin
Labels
enhancement
Milestone
3.11.16

Comments

@Zerpet
Copy link
Contributor

Zerpet commented Apr 26, 2023

Is your feature request related to a problem? Please describe.

Taking rabbitmq-queues grow as example. This command returns status code 0 and a log message hinting it did its intended job, even when the user targets a node that does not exist. For example:

rabbitmq-queues grow 'this-node-does-not-exist' all --queue-pattern some-queue
# Growing all quorum queues on this-node-does-not-exist...

Describe the solution you'd like

The CLI checks whether the target node is part of the cluster, and returns an error if it's not.

Describe alternatives you've considered

No response

Additional context

This was tested in RabbitMQ 3.11.10. This would be applicable to other CLI commands. I don't have enough knowledge of the internals to suggest other specific CLI commands 🙃
michaelklishin added a commit that referenced this issue May 2, 2023
@michaelklishin
rabbitmq-queues: validate cluster membership of the argument
d4a2d48 
Specifically of the node where new replicas should be
placed.

Closes #8007
@michaelklishin michaelklishin mentioned this issue May 2, 2023
Merged
@michaelklishin michaelklishin added this to the 3.11.16 milestone May 2, 2023
mergify bot pushed a commit that referenced this issue May 2, 2023
@michaelklishin @mergify
rabbitmq-queues: validate cluster membership of the argument
40b59fc 
Specifically of the node where new replicas should be
placed.

Closes #8007

(cherry picked from commit d4a2d48)
mergify bot pushed a commit that referenced this issue May 2, 2023
@michaelklishin @mergify
rabbitmq-queues: validate cluster membership of the argument
3c9661f 
Specifically of the node where new replicas should be
placed.

Closes #8007

(cherry picked from commit d4a2d48)
(cherry picked from commit 40b59fc)

# Conflicts:
#	deps/rabbitmq_cli/lib/rabbitmq/cli/core/validators.ex
@michaelklishin michaelklishin self-assigned this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelklishin michaelklishin

Labels
enhancement
Projects
None yet
Milestone
3.11.16
2 participants
@michaelklishin @Zerpet