Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node_health_check should list local queues only #818

Closed
michaelklishin opened this issue Jun 1, 2016 · 3 comments
Closed

node_health_check should list local queues only #818

michaelklishin opened this issue Jun 1, 2016 · 3 comments
Assignees
@michaelklishin
Labels
effort-low usability
Milestone
3.6.4

Comments

@michaelklishin
Copy link
Member

Because the command is node-scoped by definition.

@binarin WDYT?
@michaelklishin michaelklishin added this to the 3.6.3 milestone Jun 1, 2016
@michaelklishin michaelklishin self-assigned this Jun 1, 2016
@binarin
Copy link
Contributor

binarin commented Jun 2, 2016

Yes, it's the way it should be.

@michaelklishin
Copy link
Member Author

@binarin would you be interested in submitting a PR?

@binarin
Copy link
Contributor

binarin commented Jun 2, 2016

Yes, will do it in a nearest future.

@michaelklishin michaelklishin modified the milestones: 3.6.x, 3.6.3 Jun 7, 2016
binarin added a commit to binarin/rabbitmq-common that referenced this issue Jul 14, 2016
@binarin
Make rabbit_health_check completely node-local
124e72d 
Part of rabbitmq/rabbitmq-server#818

Also:
- fix queues health-checking - `rabbit_amqqueue:info_all` was expecting
  vhost argument, but was passed `[pid]` instead. So no health check was
  actually performed. Proper way is to iterate over all vhosts.
- delegate all error/timeout handling to `rabbit_cli`, so no more magic
  `70` and `68` and no more `case`-ing on `badrpc` that is already
  present in other places.
This was referenced Jul 14, 2016
Merged
Merged
@michaelklishin michaelklishin modified the milestones: 3.6.4, 3.6.x Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelklishin michaelklishin

Labels
effort-low usability
Projects
None yet
Milestone
3.6.4
Development

No branches or pull requests
2 participants
@michaelklishin @binarin