Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review use of amqqueue:get_pid and node/1 #8746

Closed
lukebakken opened this issue Jul 3, 2023 · 0 comments · Fixed by #8747
Closed

Review use of amqqueue:get_pid and node/1 #8746

lukebakken opened this issue Jul 3, 2023 · 0 comments · Fixed by #8747
Assignees
Labels
Milestone

Comments

@lukebakken
Copy link
Collaborator

Describe the bug

Related:

In VESC-1076, we see this stack trace:

Making sure data directory 'c:/Users/username/AppData/Roaming/RabbitMQ/db/rabbit@rabbitmq3-mnesia/msg_stores/vhosts/628WB79CIFDYO9LJI6DKMI09L' for vhost '/' exists
     supervisor: {<0.7418.7>,rabbit_vhost_sup_wrapper}
     errorContext: start_error
     reason: {badarg,
                 [{erlang,node,
                      [{'%2F_Queue','rabbit@rabbitmq3'}],
                      [{error_info,#{module => erl_erts_errors}}]},
                  {rabbit_classic_queue,is_recoverable,1,
                      [{file,"rabbit_classic_queue.erl"},{line,120}]},
                  {rabbit_amqqueue,'-find_local_durable_queues/1-fun-10-',7,
                      [{file,"rabbit_amqqueue.erl"},{line,182}]},
                  {qlc,collect,1,[{file,"qlc.erl"},{line,1373}]},
                  {qlc,eval,2,[{file,"qlc.erl"},{line,301}]},
                  {mnesia_tm,non_transaction,5,
                      [{file,"mnesia_tm.erl"},{line,746}]},
                  {rabbit_amqqueue,mark_local_durable_queues_stopped,1,
                      [{file,"rabbit_amqqueue.erl"},{line,167}]},
                  {rabbit_vhost_process,init,1,
                      [{file,"rabbit_vhost_process.erl"},{line,49}]}]}
     offender: [{pid,undefined},
                {id,rabbit_vhost_process},
                {mfargs,{rabbit_vhost_process,start_link,[<<"/">>]}},
                {restart_type,permanent},
                {significant,false},
                {shutdown,300000},
                {child_type,worker}]

Note the badarg. This is due to assuming you can call node/1 on the return value from amqqueue:get_pid/1

Reproduction steps

N/A

Expected behavior

N/A

Additional context

N/A

@lukebakken lukebakken added the bug label Jul 3, 2023
@michaelklishin michaelklishin added this to the 3.12.2 milestone Jul 3, 2023
mergify bot pushed a commit that referenced this issue Jul 5, 2023
mergify bot pushed a commit that referenced this issue Jul 5, 2023
Fixes #8746

(cherry picked from commit acf25b4)
(cherry picked from commit 41ce0f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants