Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usability improvements during definition import #10068 (backport #10072) (backport #10085) #10086

Merged
merged 7 commits into from Dec 10, 2023
Merged

Usability improvements during definition import #10068 (backport #10072) (backport #10085) #10086

merged 7 commits into from Dec 10, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 10, 2023

This is an automatic backport of pull request #10085 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

michaelklishin and others added 7 commits December 10, 2023 03:58
@michaelklishin @mergify
Another take at #10068
52b9519 
Scan queues, exchanges and bindings before attempting
to import anything on boot. If they miss the virtual
host field, fail early and log a sensible message.

(cherry picked from commit 62fffb6)
(cherry picked from commit e832597)
@michaelklishin @mergify
Avoid importing resources without specified virtual host
e68570e 
On boot first and foremost. Log a more helpful message.

 See #10068 for the background.

(cherry picked from commit 9d94048)
(cherry picked from commit f445d0a)
@michaelklishin @mergify
Remove a stray debug logging message
bf8be08 
(cherry picked from commit 73f0915)
(cherry picked from commit 5f2b712)
@michaelklishin @mergify
This was meant to be an OR
845c070 
Co-authored-by: Luke Bakken <luke@bakken.io>
(cherry picked from commit 75701d3)
(cherry picked from commit 1faeeb8)
@michaelklishin @mergify
Refactor parts of rabbit_definitions for dialyzability
255d935 
(cherry picked from commit 2889164)
(cherry picked from commit 67f0b89)
@michaelklishin @mergify
Rename a function to follow local module conventions better
9af4ace 
(cherry picked from commit d52af56)
(cherry picked from commit ef96e2d)
@michaelklishin @mergify
Definition import: more logging improvements
db5659c 
(cherry picked from commit 26aa534)
(cherry picked from commit 8985107)
@michaelklishin michaelklishin added this to the 3.11.27 milestone Dec 10, 2023
@michaelklishin michaelklishin merged commit 3fd6bcb into v3.11.x Dec 10, 2023
16 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v3.11.x/pr-10085 branch December 10, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.27
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@michaelklishin