Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #10535. Super Streams: check for duplicate partitions names #10712

Merged

Conversation

ikavgo
Copy link
Contributor

@ikavgo ikavgo commented Mar 11, 2024

Proposed Changes

So Add this duplicates check. See #10535.

I would love to see some sort of validation framework like in web server framework world. A chain for validation and transformation. But this code seems to be the less invasive.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@michaelklishin michaelklishin changed the title FIX #10535. Super Streams: heck for duplicate partitions names. FIX #10535. Super Streams: check for duplicate partitions names Mar 11, 2024
@michaelklishin michaelklishin merged commit 0d3a45c into main Mar 11, 2024
17 checks passed
@michaelklishin michaelklishin deleted the ik-10535-fix-duplication-ss-partition-name-error branch March 11, 2024 19:59
michaelklishin added a commit that referenced this pull request Mar 11, 2024
FIX #10535. Super Streams: check for duplicate partitions names (backport #10712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants