Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead letter cycle detection #11048

Closed
wants to merge 1 commit into from
Closed

Fix dead letter cycle detection #11048

wants to merge 1 commit into from

Conversation

ansd
Copy link
Member

@ansd ansd commented Apr 19, 2024

The desired correct dead letter cycle detection behaviour is:

If there is a death with a source queue that is the same as the target
queue name and there are no newer deaths with the 'rejected' reason then
consider this a cycle.

This commit implements this desired behaviour.
Previously, we relied on the arbitrary order of keys returned from maps:keys/1 which was wrong.

The desired correct detection behaviour is:
> If there is a death with a source queue that is the same as the target
> queue name and there are no newer deaths with the 'rejected' reason then
> consider this a cycle.

This commit implements this desired behaviour.
Previously, we relied on the arbitrary order of keys returned from maps:keys/1
which was wrong.
@ansd ansd marked this pull request as ready for review April 19, 2024 16:10
@ansd ansd requested a review from kjnilsson April 19, 2024 16:10
Copy link
Contributor

@kjnilsson kjnilsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think of the idea of "simply" changing the death records to a list that is kept in the modification order?

@ansd
Copy link
Member Author

ansd commented Apr 24, 2024

While this PR improves cycle detection, it's still not accurate in all cases because we rely on wall clock time.
Yes, a list defining a clear order of death events (across nodes) is therefore better.

@ansd ansd closed this Apr 24, 2024
ansd added a commit that referenced this pull request May 4, 2024
partial cherry pick from
#11048
ansd added a commit that referenced this pull request May 5, 2024
partial cherry pick from
#11048
@ansd ansd mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants