More efficient virtual host recovery: prepare semi-durable binding table once instead of each time a virtual host is recovered #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before #567 all binding recover functions were executed once on node restart. Executing table_filter can be expensive with high number of vhosts and bindings and effectively should be called only once. Moved to a separate function, which should be called from the global recovery function (`rabbit_vhost:recover/0`)
|
Didn't run all tests yet, but the behaviour should not be different. |
michaelklishin
changed the title
michaelklishin
changed the title
michaelklishin
approved these changes
Jul 25, 2018
michaelklishin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #567 all binding recover functions were executed once on
node restart.
Executing table_filter can be expensive with high number of vhosts
and bindings and effectively should be called only once.
Moved to a separate function, which should be called from the global
recovery function (
rabbit_vhost:recover/0).This problem exacerbated what's described in #1648.