Add support for syslog server hostname #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlagert/syslog version 3.4.3 adds support for specifying a host name for `dest_host`, this PR supports it as well See this gist for my test procedure: git@gist.github.com:7ab6348839c3dc7b18b6662f024e089c.git
lukebakken
changed the title
michaelklishin
previously requested changes
Aug 2, 2018
priv/schema/rabbit.schema
Outdated
| @@ -1086,9 +1086,8 @@ end}. | |||
| {datatype, {enum, [true, false]}} | |||
| ]}. | |||
|
|
|||
| {mapping, "log.syslog.ip", "syslog.dest_host", [ | |||
There was a problem hiding this comment.
Can we leave log.syslog.ip in place for compatibility? (it also makes some sense as an alias anyway)
There was a problem hiding this comment.
I wanted to do that, but since they both set syslog.dest_host, it doesn't work.
There was a problem hiding this comment.
Hm there may be options if the value can be transformed, maybe. Let me check.
michaelklishin
dismissed
their stale review
There are Cuttlefish limitations I wasn't aware of.
|
@michaelklishin - ready for re-review, both |
michaelklishin
approved these changes
Aug 2, 2018
|
Thanks for the review @michaelklishin |
lukebakken
added a commit
to rabbitmq/rabbitmq-website
that referenced
this pull request
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schlagert/syslog version 3.4.3 adds support for specifying a host name for
dest_host, this PR supports it as wellSee this gist for my test procedure:
https://gist.github.com/lukebakken/20bd05816a8b80839cc3c6645350bfa4