Acquire locks before starting or restarting dynamic Shovels #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When N cluster nodes are configured to import the same definition file that includes Shovel declarations, there is a natural race condition that can lead to Shovels being started on multiple nodes under the same name. See #3154 for the background.
michaelklishin
added a commit
that referenced
this pull request
Jun 30, 2021
…from-definitions Acquire locks before starting or restarting dynamic Shovels (cherry picked from commit f08c895)
michaelklishin
added a commit
that referenced
this pull request
Jun 30, 2021
…from-definitions Acquire locks before starting or restarting dynamic Shovels (cherry picked from commit f08c895)
michaelklishin
deleted the
mk-duplicate-shovels-imported-from-definitions
branch
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When N cluster nodes are configured to import the same definition
file that includes Shovel declarations, there is a natural race
condition that can lead to Shovels being started on multiple
nodes at roughly the same name.
This can be hard to spot but is guaranteed to be problematic for
Shovels that use an exchange as a source.
See #3154 for the background.
Per discussion with @kjnilsson.