Logging: Fix crash when Epoch-based timestamps are used with JSON #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was passing a number (the timestamp) to unicode:characters_to_binary/1 which expects an iolist to convert to UTF-8. We now verify if we have a number before calling that function. If this is a number (integer or float), we keep it as is because JSON supports that type.
dumbbell
force-pushed
the
fix-epoch-timestamp-crash-in-json-logging
branch
from
5131f9a
to
6c8cf4c
Compare
|
@Mergifyio backport v3.9.x |
|
Command
|
michaelklishin
added a commit
that referenced
this pull request
Aug 10, 2021
Logging: Fix crash when Epoch-based timestamps are used with JSON (backport #3281)
ansd
added a commit
to rabbitmq/cluster-operator
that referenced
this pull request
Aug 23, 2021
since rabbitmq/rabbitmq-server#3281 and rabbitmq/rabbitmq-server#3283 are merged. Example log output: {"v":7,"time":1629703633887530,"msg":"accepting AMQP connection <0.1321.0> (10.244.0.1:43532 -> 10.244.0.14:5672)","domain":"rabbitmq.connection","pid":"<0.1321.0>","gl":"<0.223.0>"}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was passing a number (the timestamp) to unicode:characters_to_binary/1 which expects an iolist to convert to UTF-8.
We now verify if we have a number before calling that function. If this is a number (integer or float), we keep it as is because JSON supports that type.