Logging: Use : as the separator in verbosity mapping
#3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
use-colon-as-verbosity_map-separator
branch
from
39bffbb
to
d685bfa
Compare
This is the same separator as the field mapping. I don't remember why I picked a different character... Now, it feels awkward and non-intuitive for users.
dumbbell
force-pushed
the
use-colon-as-verbosity_map-separator
branch
from
d685bfa
to
47e0a5f
Compare
|
Yes, backporting sounds right, the reasoning is sound and accurate. By the way, do you know @dumbbell that we now have a bot which can automatically backport? See #3284 (comment) |
|
Yes, I used to backport other patches :) |
|
@Mergifyio backport v3.9.x |
|
Command
|
michaelklishin
added a commit
that referenced
this pull request
Aug 10, 2021
Logging: Use `:` as the separator in verbosity mapping (backport #3283)
ansd
added a commit
to rabbitmq/cluster-operator
that referenced
this pull request
Aug 23, 2021
since rabbitmq/rabbitmq-server#3281 and rabbitmq/rabbitmq-server#3283 are merged. Example log output: {"v":7,"time":1629703633887530,"msg":"accepting AMQP connection <0.1321.0> (10.244.0.1:43532 -> 10.244.0.14:5672)","domain":"rabbitmq.connection","pid":"<0.1321.0>","gl":"<0.223.0>"}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same separator as the field mapping. I don't remember why I picked a different character... Now, it feels awkward and non-intuitive for users.