Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: Always represent Epoch-based timestamps as integers #3282

Merged
merged 1 commit into from Aug 10, 2021

Conversation

dumbbell
Copy link
Member

@dumbbell dumbbell commented Aug 9, 2021

Before this change, seconds were represented as floats.

@dumbbell dumbbell force-pushed the use-integers-to-represent-Epoch-based-timestamps branch from 6ab67fb to 74bc0f7 Compare August 10, 2021 10:34
Before this change, seconds were represented as floats.
@dumbbell dumbbell force-pushed the use-integers-to-represent-Epoch-based-timestamps branch from 74bc0f7 to 29bab59 Compare August 10, 2021 11:34
@dumbbell
Copy link
Member Author

dumbbell commented Aug 10, 2021

This change could be considered a breaking change. However, given the JSON logging feature is undocumented for now, I believe it can be backported.

What do you think, @gerhard and @ansd?

@dumbbell dumbbell marked this pull request as ready for review August 10, 2021 12:24
@dumbbell dumbbell merged commit bab59a7 into master Aug 10, 2021
@dumbbell dumbbell deleted the use-integers-to-represent-Epoch-based-timestamps branch August 10, 2021 12:25
@gerhard
Copy link
Contributor

gerhard commented Aug 10, 2021

Yes, and #3283 (comment)

@dumbbell
Copy link
Member Author

@Mergifyio backport v3.9.x

@mergify
Copy link

mergify bot commented Aug 10, 2021

Command backport v3.9.x: success

Backports have been created

michaelklishin added a commit that referenced this pull request Aug 10, 2021
Logging: Always represent Epoch-based timestamps as integers (backport #3282)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants