Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counters on detail pages #3422

Merged
merged 3 commits into from Sep 16, 2021
Merged

Add counters on detail pages #3422

merged 3 commits into from Sep 16, 2021

Conversation

Gsantomaggio
Copy link
Member

closes #3416

Proposed Changes

Add counters on detail pages

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

@acogoluegnes for the stream.js I could not use the .ejs script to count the items.
I used the standard java script way

an example
Screen Shot 2021-09-14 at 17 23 32

@pjk25 pjk25 merged commit 2da7c8d into master Sep 16, 2021
@pjk25 pjk25 deleted the management_ui-add-counters_3416 branch September 16, 2021 12:52
@pjk25
Copy link
Contributor

pjk25 commented Sep 16, 2021

@Gsantomaggio should this backport to 3.9 and 3.8?

@michaelklishin
Copy link
Member

@pjk25 it modifies a 3.9-specific file, I think we can keep it to v3.9.x

pjk25 added a commit that referenced this pull request Sep 16, 2021
pjk25 added a commit that referenced this pull request Sep 16, 2021
michaelklishin pushed a commit that referenced this pull request Sep 16, 2021
#3422
(cherry picked from commit 3c3450b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Management UI add counters on the detail page
4 participants