Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit policy merging for boolean keys #3880

Merged
merged 1 commit into from Dec 10, 2021

Conversation

michaelklishin
Copy link
Member

Proposed Changes

For booleans, we can prefer the operator policy value
unconditionally, without any safety implications.

Per discussion with @binarin @pjk25

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

For booleans, we can prefer the operator policy value
unconditionally, without any safety implications.

Per discussion with @binarin @pjk25
@michaelklishin michaelklishin added this to the 3.9.12 milestone Dec 10, 2021
@michaelklishin michaelklishin merged commit ec7f98e into v3.9.x Dec 10, 2021
@michaelklishin
Copy link
Member Author

@Mergifyio backport master

@michaelklishin michaelklishin deleted the mk-revisit-policy-merging branch December 10, 2021 19:47
@mergify
Copy link

mergify bot commented Dec 10, 2021

backport master

✅ Backports have been created

michaelklishin added a commit that referenced this pull request Dec 10, 2021
Revisit policy merging for boolean keys (backport #3880)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant