Disk monitor improvements #3895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoguin
reviewed
Dec 15, 2021
lukebakken
force-pushed
the
lukebakken/rabbit_disk_monitor-improvements
branch
3 times, most recently
from
e0a1d4c
to
de8eddc
Compare
lukebakken
force-pushed
the
lukebakken/rabbit_disk_monitor-improvements
branch
from
d531182
to
545da1a
Compare
lhoguin
reviewed
Dec 17, 2021
lukebakken
force-pushed
the
lukebakken/rabbit_disk_monitor-improvements
branch
from
545da1a
to
be691a0
Compare
michaelklishin
approved these changes
Dec 19, 2021
lhoguin
approved these changes
Dec 20, 2021
|
I added the ETS table after running this command to test: Since the Since the minimum update interval is 100ms I figured better safe than sorry. |
|
Can the ets:lookup functions be called before the value is first computed, and if so, can that cause an issue? |
Related to VESC-1015 * Remove `infinity` timeouts * Improve free disk space retrieval on win32 Run commands with a timeout This PR fixes an issue I observed while reproducing VESC-1015 on Windows 10. Within an hour or so of running a 3-node cluster that has health checks being run against it, one or more nodes' memory use would spike. I would see that the rabbit_disk_monitor process is stuck executing os:cmd to retrieve free disk space information. Thus, all gen_server:call calls to the process would never return, especially since they used an infinity timeout. Do something with timeout Fix unit_disk_monitor_mocks_SUITE
lukebakken
force-pushed
the
lukebakken/rabbit_disk_monitor-improvements
branch
from
3e0af4c
to
89aa4f7
Compare
lukebakken
force-pushed
the
lukebakken/rabbit_disk_monitor-improvements
branch
from
89aa4f7
to
2b63bae
Compare
|
@lhoguin thanks for the reviews. All set for the next one. |
lhoguin
approved these changes
Dec 21, 2021
lukebakken
added a commit
that referenced
this pull request
Dec 21, 2021
Disk monitor improvements (backport #3895)
lukebakken
added a commit
that referenced
this pull request
Jan 8, 2022
Fsutil has language-specific messages. Fix by using wmic.exe instead. Follow-up to #3895 Reported here: https://groups.google.com/g/rabbitmq-users/c/ypk51AtmrSM
Merged
lukebakken
added a commit
that referenced
this pull request
Jan 8, 2022
Fsutil has language-specific messages. Fix by using wmic.exe instead. Follow-up to #3895 Reported here: https://groups.google.com/g/rabbitmq-users/c/ypk51AtmrSM
lukebakken
added a commit
that referenced
this pull request
Jan 8, 2022
Fsutil has language-specific messages. Fix by using powershell.exe instead. Follow-up to #3895 Reported here: https://groups.google.com/g/rabbitmq-users/c/ypk51AtmrSM
mergify bot
pushed a commit
that referenced
this pull request
Jan 10, 2022
Fsutil has language-specific messages. Fix by using powershell.exe instead. Follow-up to #3895 Reported here: https://groups.google.com/g/rabbitmq-users/c/ypk51AtmrSM (cherry picked from commit fd78144)
michaelklishin
added a commit
that referenced
this pull request
Jan 10, 2022
Fix issue with fsutil (cherry picked from commit 98539b9)
michaelklishin
pushed a commit
that referenced
this pull request
Mar 18, 2022
Fsutil has language-specific messages. Fix by using powershell.exe instead. Follow-up to #3895 Reported here: https://groups.google.com/g/rabbitmq-users/c/ypk51AtmrSM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to VESC-1015
infinitytimeoutsThis PR fixes an issue I observed while reproducing VESC-1015 on Windows 10. Within an hour or so of running a 3-node cluster that has health checks being run against it, one or more nodes' memory use would spike. I would see that the
rabbit_disk_monitorprocess is stuck executingos:cmdto retrieve free disk space information. Thus, allgen_server:callcalls to the process would never return, especially since they used aninfinitytimeout.