Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with fsutil #3970

Merged
merged 1 commit into from Jan 10, 2022
Merged

Fix issue with fsutil #3970

merged 1 commit into from Jan 10, 2022

Conversation

lukebakken
Copy link
Collaborator

@lukebakken lukebakken commented Jan 8, 2022

Fsutil has language-specific messages. Fix by using Powershell instead.

Follow-up to #3927

Reported here:
https://groups.google.com/g/rabbitmq-users/c/ypk51AtmrSM

Update - wmic is deprecated (sindresorhus/windows-release#14)

C:\windows\system32>wmic /?

WMIC is deprecated.

Fsutil has language-specific messages. Fix by using powershell.exe instead.

Follow-up to #3895

Reported here:
https://groups.google.com/g/rabbitmq-users/c/ypk51AtmrSM
@lukebakken lukebakken marked this pull request as ready for review January 8, 2022 14:10
Copy link
Contributor

@lhoguin lhoguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least there can't be a language issue now. :)

@michaelklishin michaelklishin merged commit 98539b9 into master Jan 10, 2022
@michaelklishin michaelklishin deleted the gh-3895-bugfix branch January 10, 2022 22:15
michaelklishin added a commit that referenced this pull request Jan 10, 2022
@michaelklishin michaelklishin added this to the 3.9.13 milestone Jan 10, 2022
michaelklishin added a commit that referenced this pull request Jan 10, 2022
Fix issue with fsutil

(cherry picked from commit 98539b9)
@michaelklishin
Copy link
Member

Backported manually to v3.8.x for 3.8.28.

@lukebakken
Copy link
Collaborator Author

At least there can't be a language issue now. :)

Indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants