Fix Stream coordinator leader selection bug #3967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list consists of candidates which is a tuple {node, tail}, and the tail is made of {epoch, offset}.
While the 'select_leader' think the tail is made of {offset, epoch}.
Suppose there are two candidates:
[{node1,{1,100}},{node2,{2,99}}]
It selects node1 as the leader instead of node2 with larger epoch.
kjnilsson
changed the title
In order to retain deterministic results of state machine applications during upgrades we need to make the stream coordinator versioned such that we only use the new logic once the stream coordinator switches to machine version 1.
kjnilsson
force-pushed
the
tomyouyou-stream_select_leader
branch
from
d9a232c
to
9a5d0f9
Compare
michaelklishin
added a commit
that referenced
this pull request
Jan 8, 2022
Fix Stream coordinator leader selection bug (backport #3967)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix leader selection issue and make stream coordinator versioned so that it remains deterministic during live upgrades.