New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prometheus.erl to 4.8.2 #4376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoguin
force-pushed
the
loic-update-prometheus.erl
branch
from
March 30, 2022 10:37
d45f372
to
a982ba0
Compare
lhoguin
force-pushed
the
loic-update-prometheus.erl
branch
from
March 30, 2022 10:38
a982ba0
to
2a24662
Compare
Waiting for confirmation that the problem is gone before removing draft status. |
michaelklishin
added a commit
that referenced
this pull request
Apr 2, 2022
michaelklishin
added a commit
that referenced
this pull request
Apr 2, 2022
michaelklishin
added a commit
that referenced
this pull request
Apr 2, 2022
Proactively add #4376 to 3.10.0 release notes
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2022
(cherry picked from commit 7bfd744)
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2022
(cherry picked from commit db6bdb4)
michaelklishin
added a commit
that referenced
this pull request
Apr 2, 2022
michaelklishin
added a commit
that referenced
this pull request
Apr 2, 2022
Proactively add #4376 to release notes
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2022
(cherry picked from commit ea8f6da)
michaelklishin
approved these changes
Apr 2, 2022
michaelklishin
added a commit
that referenced
this pull request
Apr 3, 2022
Update Prometheus.erl to 4.8.2 (backport #4376)
Just to make sure the milestone does not confuse anyone. This will also be included into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to figure out the sha.
Includes the fix for deadtrickster/prometheus.erl#133
Proposed Changes
Please describe the big picture of your changes here to communicate to the RabbitMQ team why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
A pull request that doesn't explain why the change was made has a much lower chance of being accepted.
If English isn't your first language, don't worry about it and try to communicate the problem you are trying to solve to the best of your abilities.
As long as we can understand the intent, it's all good.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.