Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: check unsupported policies on queue.declare #4463

Merged
merged 1 commit into from Apr 9, 2022
Merged

Bugfix: check unsupported policies on queue.declare #4463

merged 1 commit into from Apr 9, 2022

Conversation

dcorbacho
Copy link
Contributor

@dcorbacho dcorbacho commented Apr 8, 2022 •
edited

The amqqueue record does not exist when rabbit_amqqueue:is_policy_applicable/2
is called. It is available in rabbit_policy, so let's send it through.

Reported in #4174

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

@dcorbacho
Bugfix: check unsupported policies on queue.declare
9bbfcdb 
The amqqueue record does not exist when `rabbit_amqqueue:is_policy_applicable/2`
is called. It is available in `rabbit_policy`, so let's send it through.
@michaelklishin michaelklishin self-assigned this Apr 9, 2022
@michaelklishin michaelklishin merged commit 296566c into master Apr 9, 2022
@mergify mergify bot mentioned this pull request Apr 9, 2022
Merged
@michaelklishin michaelklishin deleted the unsupported-policies-queue-declare branch April 9, 2022 03:47
michaelklishin added a commit that referenced this pull request Apr 9, 2022
@michaelklishin
Merge pull request #4476 from rabbitmq/mergify/bp/v3.10.x/pr-4463
478daba 
Bugfix: check unsupported policies on queue.declare (backport #4463)
michaelklishin added a commit that referenced this pull request Apr 9, 2022
@michaelklishin
Merge pull request #4479 from rabbitmq/mergify/bp/v3.9.x/pr-4476
be6d2ce 
Bugfix: check unsupported policies on queue.declare (backport #4463) (backport #4476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees

@michaelklishin michaelklishin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dcorbacho @michaelklishin