Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documented/allowed log_level arg of rabbitmqctl set_log_level #4793

Merged
merged 1 commit into from May 11, 2022

Conversation

gomoripeti
Copy link
Contributor

Proposed Changes

The critical log level is already documented on the website/logging section.

Related to the discussion in rabbitmq/rabbitmq-website#1404

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

The `critical` log level is already documented on the website/logging section.
@michaelklishin michaelklishin merged commit 7107e3e into rabbitmq:master May 11, 2022
michaelklishin added a commit that referenced this pull request May 11, 2022
Clarify documented/allowed log_level arg of rabbitmqctl set_log_level (backport #4793)
michaelklishin added a commit that referenced this pull request May 11, 2022
Clarify documented/allowed log_level arg of rabbitmqctl set_log_level (backport #4793) (backport #4794)
michaelklishin added a commit that referenced this pull request May 11, 2022
Clarify documented/allowed log_level arg of rabbitmqctl set_log_level (backport #4793) (backport #4794) (backport #4795)
@gomoripeti gomoripeti deleted the log_levels branch May 12, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants