Remove pre-implicit_default_bindings compatibility code #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
force-pushed
the
remove-pre-implicit_default_bindings-ff-compatibility-code
branch
2 times, most recently
from
8d21c39
to
244efd8
Compare
Implicit default bindings, introduced in RabbitMQ 3.8.x, was a breaking change protected behind a feature flag. This allowed a RabbitMQ cluster to be upgraded one node at a time, without having to stop the entire cluster. The compatibility code is in the wild for long enough. The `implicit_default_bindings` feature flag was marked as required in a previous commit (see #5202). This allows us to remove code in this patch. References #5215.
…ings The feature flag is required. References #5215.
ansd
force-pushed
the
remove-pre-implicit_default_bindings-ff-compatibility-code
branch
from
244efd8
to
32e118f
Compare
michaelklishin
approved these changes
Jul 29, 2022
michaelklishin
deleted the
remove-pre-implicit_default_bindings-ff-compatibility-code
branch
michaelklishin
added a commit
that referenced
this pull request
Jul 29, 2022
Remove pre-implicit_default_bindings compatibility code (backport #5390)
dumbbell
pushed a commit
that referenced
this pull request
Aug 4, 2022
…ndings-ff-compatibility-code Remove pre-implicit_default_bindings compatibility code (cherry picked from commit 7980ee8)
|
The backport was repeated in #5439. |
dumbbell
added a commit
that referenced
this pull request
Aug 4, 2022
Remove pre-implicit_default_bindings compatibility code (backport #5390)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit default bindings, introduced in RabbitMQ 3.8.x, was a breaking change protected behind a feature flag. This allowed a RabbitMQ cluster to be upgraded one node at a time, without having to stop the entire cluster.
The compatibility code is in the wild for long enough. The
implicit_default_bindingsfeature flag was marked as required in aprevious commit (see #5202). This allows us to remove code in this patch.
References #5215.
Note that we rely here on dirty Mnesia operations of the removed migration function to have done its job (of removing default exchange binding rows).