Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialyzer warnings rabbit v3.11.x #7024

Closed
wants to merge 1,121 commits into from
Closed

Conversation

binarin
Copy link
Contributor

@binarin binarin commented Jan 24, 2023

  • Revert "Bump the rabbitmq version on this branch to 3.12.0 (bazel)"
  • Fix stream command name
  • Remove binding from rabbit_index_route if exchange not found
  • Set read lock on rabbit_exchange during rabbit_index_route migration
  • Add test for routing from exchange to exchange
  • Remove implicit_default_bindings compatibility code
  • Remove test code which depended on feature flag implicit_default_bindings
  • Resolve a conflict
  • Don't try to create connection tracking tables in rabbit_mnesia
  • Channel PID as primary key of channel tracking table
  • Add conditional logging to text formatter.
  • Replace JSX with Thoas for JSON operations
  • Swap JSX for Thoas in more places
  • Pin Thoas to 0.3.0 in one more place
  • Remove a few tests that are no longer relevant
  • rabbit_json:decode/1: use erlang:error/1 like the JSX version did
  • Remove old reference to external trust-store-http
  • Begin adapting logging_SUITE for Thoas
  • Adapt JSON logging test for Thoas
  • rabbitmqadmin_SUITE: only use Python 3, Python 2 is really truly EOL
  • Pin erlang-jose to our fork with Thoas support
  • rabbitmqadmin_SUITE: encode value as bytes on Python 3
  • rabbit_aws: adapt for Thoas-based rabbit_json
  • rabbit_json:decode/2: raise a two-tuple error
  • rabbit_policy: correctly format JSON decoding errors that are tuples
  • rabbit_vhost_limit: correctly format JSON decoding errors that are tuples
  • rabbit_auth_backend_internal: correctly format JSON decoding errors that are tuples
  • rabbit_runtime_parameters: correctly format JSON decoding errors that are tuples
  • rabbit_runtime_parameters: correctly format JSON decoding errors that are tuples in one more place
  • rabbit_auth_backend_internal: correctly format JSON decoding errors that are tuples
  • Resolve a conflict
  • README edits
  • 3.10.7 release notes
  • 3.9.22 release notes
  • 3.10.7 release notes: correct a broken link
  • Update 3.10.7 release notes
  • Update 3.9.22 release notes
  • Remove pre-virtual_host_metadata feature flag compatibility code
  • Remove test code which depended on the virtual_host_metadata feature flags
  • ctl add_vhost: check if relevant feature flags are enabled
  • Validate the feature flag behind user-provided queue type on the server end
  • close 3.11: definition import ignores virtual hosts' default queue type setting #5399, set default vhost queue type from import's metadata
  • Resolve a conflict
  • Resolve a conflcit
  • 3.10.7 shipped with Osiris 1.3.0
  • Bump erlef/setup-beam from 1.11 to 1.12
  • Follow-up for 3.11: definition import ignores virtual hosts' default queue type setting #5399. Add new vhost information items to the list
  • rabbitmqctl(8): document optional args supported by add_vhost
  • rabbitmqctl(8): correct add_vhost option dashes
  • Revert "Merge pull request Remove pre-virtual_host_metadata feature flag compatibility code (backport #5236) #5409 from rabbitmq/mergify/bp/v3.11.x/pr-5236"
  • Follow-up to the revert in commit dcff9a2
  • Follow-up to the revert in commit dcff9a2
  • Revert "Merge pull request Remove pre-implicit_default_bindings compatibility code (backport #5390) #5394 from rabbitmq/mergify/bp/v3.11.x/pr-5390"
  • Follow-up to the revert in commit dcff9a2
  • Remove pre-user_limits compatibility code
  • Remove test code which depended on the user_limits feature flags
  • Remove pre-maintenance_mode_status compatibility code
  • Remove test code which depended on the maintenance_mode_status feature flags
  • Merge pull request Remove pre-virtual_host_metadata feature flag compatibility code #5236 from rabbitmq/remove-virtual_host_metadata-ff-compatibility-code
  • Remove pre-quorum-queue compatibility code
  • rabbitmqctl.8: Use stream_queue in the enable_feature_flag example
  • Remove test code which depended on the quorum_queue feature flags
  • Merge pull request Remove pre-implicit_default_bindings compatibility code #5390 from rabbitmq/remove-pre-implicit_default_bindings-ff-compatibility-code
  • rabbit_auth_backend_internal: Reduce diff with master by adjusting indentation
  • CQv1: Fix failure to recover messages in rare cases
  • Prevent global:sync/0 from being stuck
  • Log at debug level when "global hang workaround" is applied
  • Drop Erlang 23 from Actions test matrix
  • Terraform: Erlang packages for 24 and 25 have long been available
  • Bump minimum required Erlang version to 24.3
  • Terraform: add AMIs for Fedora 34 and 35
  • Bump actions/cache from 3.0.5 to 3.0.6
  • Don't delete durable CQs from rabbit_queue table on node down
  • Add delete connection by username feature
  • Disable a test that needs revision post-Don't delete durable queues from rabbit_queue table on node down #4563
  • Enable a post-Don't delete durable queues from rabbit_queue table on node down #4563 test
  • Add StreamInfo command to stream protocol
  • Make process liveness check remote if necessary
  • Keep stream_* return codes
  • Rename StreamInfo to StreamStats
  • Use atom_to_binary/1 instead of rabbit_data_coercion
  • Fix failing test
  • Bump eetcd to 0.3.6
  • Streams: adapt tests to the latest Java stream client listener interface
  • Bump dependencies in stream Java test
  • update prometheus to 4.9. close Rename erlang_vm_statistics_run_queues_length_total #4380
  • amqp10_client system test suite reliability
  • Bump actions/cache from 3.0.6 to 3.0.7
  • Remove dependency on rabbit_channel in classic queues
  • Simplify check for non-amq exchanges
  • Use rules_erlang 3.5.0
  • Remove all of the .travis.yml files
  • Remove .travis.yml.patch files
  • Update amqp*_client Makefiles for branch rename
  • Update GitHub Actions and Mergify for branch rename
  • Add missing rabbitmq-upgrade to rabbitmq_home.bzl
  • Also add rabbitmq-streams & rabbitmq-tanzu
  • Connect ssl:connect in amqp10_client with hostname
  • Sync prometheus version between MODULE.bazel & workspace_helpers
  • Fix badmatch by taking edge case into account
  • Ensure CONF_ENV_FILE is run correctly on win32
  • Force gc while importing definitions
  • Bump peter-evans/create-pull-request from 4.0.4 to 4.1.1
  • Add platforms repo to MODULE.bazel
  • Adopt otp 24.3.4.3
  • Adopt otp 25.0.4
  • Use latest rbe-erlang-platform/linux-rbe
  • Remove an old check
  • Check for vhost's existence every 5 seconds
  • Add a bazel based OCI image build to the oci.yaml workflow
  • Exclude docker image tests from the normal test workflows
  • Add sha256s for otp source archives
  • Remove unused workflow
  • Bump docker/login-action from 1 to 2
  • Bump docker/setup-buildx-action from 1 to 2
  • Bump docker/build-push-action from 2 to 3
  • Bump actions/cache from 3.0.7 to 3.0.8
  • rabbitmq-diagnostics(8): correct a flag
  • Apply Add missing '-' to 'number' parameter rabbitmq-website#1462 at the source (man pages)
  • Fix a typo in a comment in prometheus_rabbitmq_core_metrics_collector
  • Fix a typo in a comment in rabbit_env
  • Adopt otp 24.3.4.3
  • Use erpc:multicall in rabbit_tracking:count_tracking_items_in_ets
  • Refactor rabbit_(connection|channel)_tracking:count_tracking_items_in_ets
  • Only look for tracked channels of a closed connection locally
  • Adopt otp 25.0.4
  • Support rich authorization request spec
  • Make aud field optional
  • Fix issue where the cluster was wrongly matched
  • Remove print statement
  • Allow regular expression in location's cluster field
  • Use wildcard library rather than re
  • Update docs
  • Explain how the permissions translate to scopes
  • Explain how permissions are translated to scopes
  • Improve readability
  • Correct mistake in the translation example
  • Test single value for locations and actions
  • Add missing test cases
  • Use user-tags without prefix tag: as action name
  • Update docs
  • Update documentation
  • README edits
  • OAuth 2: README edits
  • OAuth 2: README edits
  • OAuth 2 Cuttlefish schema: cosmetics
  • OAuth 2: one more RAR doc edit
  • OAuth 2: more RAR doc edits
  • OAuth 2: edits per discussion with @MarcialRosales
  • OAuth 2 README: add a missing link
  • README edits
  • OAuth 2: use a separate system suite group for RAR
  • OAuth 2: unit_SUITE naming and wording
  • OAuth 2: rename a function
  • Exclude OCI targets from wildcards like bazel test //... ...
  • Fix typo
  • Update prometheus to 4.9.1
  • Update workspace_helpers.bzl to match Update prometheus to 4.9.1 #5647
  • Fix duplicate credit grant in quorum queue
  • Introduce new credit_mode {simple_prefetch, MaxCredits} for v3
  • Use long form "andalso" for clarity
  • Update to supported Grafana and Prometheus versions
  • Migrate from deprecated panels in Grafana
  • Take dashboard definitions straight from exported Grafana for simplicity
  • Set time series to show all series in tooltip
  • Fix dist link graph
  • Fix overview graphs in Grafana 9
  • Add README.md for creating/updating dashboards
  • Avoid crash when client disconnects before server handles MQTT CONNECT
  • Fix failing proxy_protocol test
  • Adopt otp 24.3.4.4
  • Squash a few compiler warnings
  • Introduce a concept of release series EOL date
  • Report version series maintenance status via CLI
  • Release series support: wording
  • Release series support: announce in more places
  • Log release series EOL message as an error
  • Basic unit tests for rabbit_date_time
  • Control supervisor2 error reports with application variable to be set in e.g. the advanced.config file, or manually in runtime.
  • Add a test_event_handler for rabbit_common event based tests
  • Implement tests for controlling supervisor2 error reports. Tests behaviour controlled at compile time through, macro.
  • Use SupPID provided in ?TRACE_SUPERVISOR2_ERROR_LOG macro through SupName.
  • Use local include to reference rabbit.hrl in test_event_handler
  • Inlcude test_event_handler in rabbit_common supervisor2_SUITE bazel
  • Rename TRACE_SUP2 to TRACE_SUPERVISOR2 and add to Makefile
  • Ensure clean shutdown of rabbit_event manager in supervisor2_SUITE to avoid noisy test terminations
  • Bump deps: michaelklishin/erlang-jose and Thoas
  • Use otp 24.3.4.4
  • Use OTP 25.0.4 to build RabbitMq docker image
  • Upgrade MQTT Erlang client
  • Set ERL_MAX_ETS_TABLES and ERL_MAX_PORTS in the same manner as on Windows
  • Bump Aten to 0.5.8
  • 3.11.0 release notes stub
  • Initial 3.11 release notes
  • 3.11.0 release notes edits based on initial feedback
  • Replace singular with oidc-client-ts library
  • Set cookies expiry from token expiry claim
  • Refresh token
  • WIP login/logout/token-refresh against keycloak
  • Handle scopes
  • Handle rabbitmq session timeout
  • Handle not authorized oauth user
  • Fix two issues
  • Add audience request parameter to /authorize
  • Test home page with oauth2 and without token
  • Explain how automated testing works
  • Explain what it is needed to run tests
  • Testing happy login for oauth
  • Auto approve scopes
  • Complete login and logout flows
  • Run tests
  • Remove dummy state
  • WIP running selenium tests from docker
  • WIP only landing.js working
  • WIP Using PageObject pattern to write tests
  • Tested landing page
  • WIP fixing test case happy-login.js using ObjectPages
  • Verify happy-login scenario
  • Verify login,logout when uaa is up
  • Issue found on token refresh
  • Fix issue related to refreshing access tokens
  • Document testing
  • Comment why test last 20sec
  • WIP prepare to run all tests
  • Fix auth_test
  • Fix test case oauth_test
  • Ensure first oauth2 plugin is configured
  • Enable oauth2 plugin
  • Improve docs and fix some mistakes on the selenium tests
  • Add first commit for github action to run
  • Move it temporary to a feature branch
  • Run selenium tests with Actions
  • Run action against oidc-integration branch
  • Capture UAA logs before killing it
  • Explain how to launch rabbitq from source
  • Skip logout selenium test
  • Fix logout workflow
  • Refactor how selenium tests are run
  • Test hard session timeout
  • Fix location of uaa configuration
  • Use OTP 25.0.4 to build RabbitMq docker image
  • Fix wrong folder name
  • Improve wording
  • OAuth 2 Selenium suite: bump selenium-webdriver and chromedriver
  • Enable only 2 plugins not all
  • Logging improvements
  • Wait till token TTL before checking again
  • Update how to wait for UAA
  • Fix location of script waitTillUAAReady
  • Fix bug in start-uaa.sh script
  • management.oauth_enable => management.oauth_enabled
  • Management plugin: oauth_enable => oauth_enabled in more places
  • Add missing renamed oauth.enable -> oauth.enabled
  • Simplify make targets
  • Point emqtt test dependency to a tree reference
  • Make CLI tools version reflect that of RabbitMQ itself on this branch
  • CLI tools: whitelist Elixir 1.14
  • Resolve conflicts
  • Update 3.11.0.md
  • Fix MQTT protocol version in MQTT tests
  • Remove debug log messages from stream SAC coordinator
  • Remove experimental warning in super stream commands
  • 3.11 release notes: wording as suggested in HTTP API: allow connections to be listed and closed by username #5319
  • Fix typo in plugins.mk
  • Disk monitor strikes back!
  • Add a Bazel rule for test/disk_monitor_SUITE.erl
  • Drop unit_disk_monitor_mocks_SUITE from BUILD.bazel
  • Fix flaky rabbit_fifio_int:credit tests
  • Stop sending stats to rabbit_event
  • Add gen_event behaviour declaration
  • Remove rabbit_misc:atom_to_binary/1
  • Use maps:get/3
  • Move message rate metrics from channel/queue aggregation to global counters
  • Rename and fix rabbit_stream_metrics_gc childspec identifier from supervisor context
  • Add login_timeout to mqtt and stomp reader
  • Bump erlef/setup-beam from 1.12 to 1.13
  • The default-queue-type property on a vhost was added recently in Configure default queue type by vhost #5305 to aid a workflow for converting to quorum queues. The core logic of that change was applying some special logic which injects x-queue-type into arguments on a queue when it is declared.
  • Better defaults for queue properties when importing definitions
  • Use credit flow for dest side of on-publish shovels
  • Adopt otp 24.3.4.5
  • Federation: begin reworking exchange_SUITE for Erlang 25
  • One more exchange federation test
  • Port one more exchange federation test
  • Port more exchange federation tests for Erlang 25
  • Port more tests
  • Port more exchange federation tests
  • Update federation BUILD.bazel to refresh test suite changes
  • Federation: move exchange link status test to exchange_SUITE
  • Federation: move another test to exchange_SUITE
  • he ssl:ssl_option() type was renamed to ssl:tls_option() in this commit: erlang/otp@e042afe which was merged in OTP 21.3 This change prevents dialyzer warning: :0:unknown_type Unknown type: :ssl.ssl_option/0.
  • Use tlsv1.2 in //deps/rabbitmq_trust_store:system_SUITE
  • Re-enable Erlang 25 in Actions
  • rabbit_trust_store:load_and_decode_cert/4: be more defensive
  • Require Erlang/OTP 25.0 (3.11 and 3.12/main only)
  • Require Elixir 1.13.4 or 1.14.x
  • Resolve a conflict
  • Add elixir 1.14 to bazel
  • Disable failing github actions step for now
  • (Possibly temporarily) remove non-Bazel OCI image builds
  • Resolve a conflict
  • Updates to 3.11.0 release notes
  • One more update to 3.11.0 release notes
  • Implement header conversion between AMQP 1.0 and 0.9.1
  • fix formatting
  • Use rules_erlang 3.6.3
  • Bump docker/login-action from 1 to 2
  • Merge pull request Update the selenium test actions workflow #5833 from rabbitmq/pjk25/update-selenium-workflow
  • Add Erlang 25.1 to Actions matrix
  • Point emqtt test dependency from ansd to emqx
  • Bump peter-evans/create-pull-request from 4.1.1 to 4.1.2
  • Use rules_cc 0.0.2
  • Add rabbitmq-streams manpage
  • Add stream plugin commands to rabbitmq-streams man page
  • Add links to rabbitmq-streams man page
  • 3.9.23 release notes
  • 3.9.23 release notes: a typo
  • 3.10.8 release notes
  • Complement rabbitmq-stream.8 with SAC and super streams
  • Pin Osiris to 1.3.1 and Ra to 2.3.0 (Pin Osiris to 1.3.1 and Ra to 2.3.0 #5863)
  • Add back an accidentally removed Ra runtime dep to workspace_helpers.bzl
  • Minor typos fix (Minor typos fix #5865) (Minor typos fix (backport #5865) #5867)
  • 3.10.8 release notes wording
  • Filter out elixir compilation from local execution in bazel (Filter out elixir compilation from local execution in bazel #5869) (Filter out elixir compilation from local execution in bazel (backport #5869) #5870)
  • 3.10.8 release notes: correct a typo
  • Adopt otp 25.0.4 (backport Adopt otp 25.0.4 #5873) (Adopt otp 25.0.4 (backport #5873) #5874)
  • Mark the rbe repo as a dev dependency
  • Adopt otp 24.3.4.5
  • mapping deliverycount if present in headers
  • Apply the @erlang_config pattern for elixir via the WORKSPACE
  • Bump peter-evans/create-pull-request from 4.1.2 to 4.1.3
  • fixup auto-backport conflicts
  • Adopt elixir 1.13.4
  • Add option for wildcard certificates to docs
  • Fixup config drift causing the Windows Actions to fail
  • Enhance inference of ELIXIR_HOME from the path of iex/elixir
  • Add erlang 25.1 to github actions
  • Match ra definition in workspace_helpers.bzl with MODULE.bazel
  • WIP verify 1 connection listed
  • Add failing test that list a single connection
  • Test listing 091 connections
  • Add failing test
  • Verified amqp 1.0 conn are tracked
  • WIP reader process was under different supervisor
  • Fix issue listing amqp 1.0 connections
  • Refactor test that verifies one amqp 1.0 conn
  • Remove unnecessary test
  • Clean up code and use ct:pal over println
  • Use correct expr. to extract field from record
  • Update branch names and links
  • Make ensure_monitors more defensive in SAC coordinator
  • Add //tools:erlang_ls_files that generates a tree for Erlang LS
  • Change variable name
  • Turn the //tools:erlang_ls.config target into a generation script
  • Attempt to make generated erlang_ls.config more stable
  • Remove commented code
  • Bump actions/cache from 3.0.8 to 3.0.9
  • Add otp 25.1 to //packaging/docker-image:rabbitmq
  • Simplify otp src selects in //packaging/docker-image:otp_source
  • Use leader locator "balanced" by default for add_super_stream
  • Use rules_erlang 3.7.2
  • initial .formatter.exs configuration file
  • mix format rabbitmq_cli
  • remove deprecated and replace with import Config module
  • add rabbitmq_cli format check on make/mix task aliases
  • update contribution notes with rabbitmq_cli formatting instructions
  • extend contribution note on cli format checking
  • Fix keys for route and partitions responses
  • Resolve a conflict
  • Bump actions/cache from 3.0.9 to 3.0.10
  • Ensure consumer msg_id state is synchronised
  • Change rabbit_fifo_client get_missing_deliveries to use aux_command
  • Use supervisor2 specifications in stream connection supervisor
  • Remove auto_shutdown from supervisor2 flags
  • Adopt otp 25.1.1
  • Use Elixir 1.13.x with otp 24.x in bazel build
  • Add 'mix format --check-formatted' to the rabbitmqctl_tests in bazel
  • fix docs for rabbitmqctl restart_vhost
  • Update Stream protocol document
  • Support management path prefix when using OAuth2
  • Improve wording of how to run selenium tests
  • Support multiple path segments in management path
  • Refactor quorum queue periodic metric emission
  • Introduce new feature flag to avoid crashing channel.
  • Resolve conflicts
  • Upgrade cuttlefish to 3.1.0
  • Load plugins in dependency order
  • Adopt otp 24.3.4.6
  • Remove unused fields from shovel_worker state record
  • Fix table layout for terminated shovel status
  • Fix error handling of shovel_management delete/restart shovel
  • rabbitmq_shovel_management tests need meck
  • Resolve a conflict
  • Make "global hang workaround" support OTP >= 25.1
  • Simplify code
  • Add a classic queue observer_cli plugin
  • Backport the CQ observer plugin to 3.10 and 3.11
  • Remove erlang 23 from bazel build
  • Make rabbit_fifo_basics_SUITE:basics less dependent on ra_event order
  • Adopt elixir 1.14.1
  • Drop Elixir 1.12 toolchain
  • Remove elixir 1.12 in a few other files
  • 3.11.1 release notes
  • 3.10.9 release notes
  • Implement ra_machine:overview/1 for rabbit_stream_coordinator
  • Close local MQTT connections when draining node
  • Resolve a conflict
  • Avoid double debiting credit when sending to queue mirrors.
  • Bump actions/cache from 3.0.10 to 3.0.11
  • Handle a rare case with multiple dist ports
  • Use rules_erlang 3.8.2
  • Partially revert delegate optimisation
  • Bump peter-evans/create-pull-request from 4.1.3 to 4.1.4
  • 3.10.10 release notes
  • 3.11.2 release notes
  • 3.9.24 release notes
  • Adjustments to the OCI workflow to ensure the correct otp version
  • Correct a copy-and-paste artifact in 3.9.24 release notes
  • Adopt rules_erlang 3.8.3
  • Add otp 25.0 to the matrix in the non-mixed tests in actions
  • Bump peter-evans/create-pull-request from 4.1.4 to 4.2.0
  • 3.11.x release notes wording
  • Stream coordinator: fix member check in ensure_coordinator_started/0
  • Sync the approach in oci.yaml workflow across branches
  • Add ability to set default vhost limits by pattern
  • Rename a schema key
  • Update default virtual host limit tests
  • Rename a couple of snippets
  • Resolve a conflict
  • Add a --test_build flag for building the broker for mixed versions
  • Correct ra and osiris versions under Make
  • Make rabbit_fifo_int_SUITE:basics test less flaky
  • Bump erlef/setup-beam from 1.13 to 1.14
  • Add noopener to hrefs in rabbitmq_management
  • Fix ack crashes when using CMQs with v2
  • Bump lewagon/wait-on-check-action from 1.1.2 to 1.2.0
  • Make secrets optional in Windows workflow
  • Ignore .exrc file
  • Resolve a conflict
  • Shovel: handle connection.(un)blocked messages from dest broker
  • Optimise shovel pending queue handling for flow-control
  • SC: fail active mnesia update actions on leader change
  • Reduce CT logging here
  • Wording
  • Stream coordinator: fix merge conflicts and rewording
  • Fix the CQ Observer CLI plugin with clusters
  • AMQP 1.0: Support the modified outcome
  • Adopt otp 25.1.2
  • Update lqueue based on OTP-25.1.2
  • Update README.md
  • Apply Update rabbitmq-diagnostics.8.html rabbitmq-website#1508 at the source (man pages)
  • Correctly decrease global counters in rabbit_channel:terminate/2
  • Mark @rbe as non-dev dependency
  • Use @rules_erlang//:debug_build instead of //:debug_build
  • Rework package_generic_unix & source_archive bazel macros
  • Use .tar.xz extension for //:source_archive bazel target
  • QQ: don't try to contact non-connected nodes for starts
  • wrap erpc:call
  • Avoid crashing shovel plugin when another node goes down
  • Use erpc optimisation for local rpcs
  • CLI: improve isolation of set_disk_free_limit tests
  • ctl status: handle cases when free disk space cannot be computed
  • Refine and fix AMQP 1.0 modified outcome behaviour
  • Fail fast in the rabbitmq_cli tests if test_helper.exs is missing
  • Explain that 'bazel clean' helps with this odd condition
  • Copy rather than symlink files in rabbitmqctl_test.bzl
  • Split rabbitmq_cli format check into a separate test target in bazel
  • Reduce unnecessary setup in rabbitmq_cli formatting check
  • Fixup format check on windows
  • Filter the rabbitmq_cli format check out on windows
  • Remove trust_store_http from MODULE.bazel since it's an internal dep
  • Squash a couple of warnings
  • See Issue 6020. Take plugin dependency into account
  • See Issue 6020. Add rabbitmq_stream_management plugin to test suite
  • Reset enabled plugins after each test that enables any
  • CLI: continue reworking assertions on plugin state
  • Adopt new helpers that assert on plugin presence and state
  • rabbitmq-run: make sure that plugin directory is created
  • Bazel: set RABBITMQ_PLUGINS_DIR for tests
  • CLI: do not fail if plugin directory does not exist
  • Revert "Bazel: set RABBITMQ_PLUGINS_DIR for tests"
  • Remove duplicate dep_thoas declaration
  • Resolve a conflict
  • Make counterspec key unique in rabbit_stream_queue
  • Streams: close osiris log on unsubscribe
  • Upgrade osiris version to v1.3.2
  • Be more explicit with timeouts when declaring quorum queues
  • Resolve conflicts
  • Adopt otp 25.1.2
  • Adopt elixir 1.14.1
  • Adopt elixir 1.13.4
  • Adopt otp 25.0.4
  • Bump Ra to 2.4.0
  • 3.9.25 release notes
  • 3.10.11 release notes
  • Bump Ra for Erlang.mk
  • Update 3.10.11 release notes
  • Bump Osiris to 1.3.3
  • Seshat 0.4.0
  • Bump credentials_obfuscation to 3.2.0
  • Bump Ra to 2.4.1
  • Resolve conflicts
  • 3.11.3 release notes
  • Update 3.10.11 release notes
  • Update 3.9.25 release notes
  • Update 3.10.11 release notes
  • Update 3.11.3 release notes
  • Update 3.11.3 release notes
  • Aggregate memory usage on ra_server_sup_sup level
  • Update 3.11.3 release notes
  • fix rabbit_direct_reply_to:compute_key_and_suffix_v1 type signature
  • Support code coverage
  • Bump erlang.mk
  • Support coverage when node being killed by index
  • Add inclusive aliases to ctl info keys
  • rabbitmqctl(8) wording
  • See Channel state contains un-obfuscated user data #4842. Obfuscate impl value
  • See Channel state contains un-obfuscated user data #4842. Fix broken test
  • load_definitions should fail on invalid JSON
  • Support x-max-age argument in stomp
  • Use assertMatch instead of assertEqual in test
  • Bump actions/upload-artifact from 2.pre.preview to 3.1.1
  • Filter out global runtime parameters not meant to be exposed
  • Osiris 1.4.0
  • Consider streams when quorum critical check (Consider streams when quorum critical check #6448)
  • Get counters from stream replicas first (Get counters from stream replicas first #6442) (Get counters from stream replicas first (backport #6442) #6449)
  • Bump erlef/setup-beam from 1.14 to 1.15
  • Bump peter-evans/create-pull-request from 4.2.0 to 4.2.1
  • Bump peter-evans/create-pull-request from 4.2.1 to 4.2.2
  • QQs: hint Ra at taking a snapshot when a consumer is added
  • Update to .NET 7
  • Update README.md
  • Use sets v2 for better performance
  • Remove unnecessary call to priority_queue:len/1
  • Remove GS2 priorities from rabbit_mirror_queue_slave
  • Bring back some of the priorities
  • Updated django url to re_path
  • Fix case_clause crash when stream queue provided for quorum queue cmds
  • Exclude a new QQ test from mixed version runs
  • Exclude one more new QQ test from mixed version runs
  • Initial 3.10.12 release notes
  • 3.10.12 release notes wording
  • Initial 3.11.4 release notes
  • Initial 3.9.26 release notes
  • Bump peter-evans/create-pull-request from 4.2.2 to 4.2.3
  • CQ: Remove an assert causing issues on SAC switch
  • Add rabbit_fifo_dlx_worker test
  • Add log when channel stops with pending confirms
  • feature_flags_SUITE: Test a plugin's feature flag is enabled after a node restart
  • rabbit_feature_flags: Fix the loading of a plugin's feature flag states
  • rabbit_feature_flags: Revisit the trick we use to convince Dialyzer
  • rabbit_feature_flags: Fix spec of run_callback()
  • rabbit_feature_flags: Change an assertion to fix a Dialyzer warning
  • See Disk free limit and memory high water mark "relative" configuration always takes precedence over "absolute" configuration #4980. Give *.absolute precedence over *.relative configuration
  • rabbit_runtime_parameters: Fix event when clearing a global runtime parameter
  • Follow-up to Run rabbitmq-env-conf.bat on win32 taking spaces into account #5486
  • Log errors from unicode:characters_to_list
  • Fix rabbit_misc:hexify/1 when called with a list
  • Fix dialyzer warnings in rabbit_common
  • Fixes for various dialyzer warnings
  • Turn strict dialyzer back on for some deps
  • Fix a name mismatch when bazel is used without bzlmod
  • Make rabbit_disk_monitor more resilient
  • Sync rabbit_disk_monitor with main
  • Expose effective policy definition via CLI
  • rabbitmqctl(8): wording
  • 3.10.13 release notes
  • Update 3.11.1.md
  • 3.11.5 release notes
  • Update Ra to 2.4.3
  • Add deps info for ra when it is fetched from hex.pm
  • Add configuration key in rabbit app
  • Resolve conflicts
  • Update 3.10.13 release notes
  • Update 3.11.5 release notes
  • Adopt otp 25.1.2
  • Adopt elixir 1.13.4
  • Adopt otp 25.0.4
  • Modify rabbit_sharding_exchange_decorator boot requirements
  • QQ: introduce configuration for mem table compression.
  • Update 3.11.5 release notes
  • Update other exchange decorators
  • Copy rather than symlink rabbitmqctl in bazel
  • Allow bazel run rabbitmq-streams
  • Consistently expose default queue functionality in management UI
  • Fix error filtering and printing in queue grow/shrink commands
  • Make rabbitmqctl with no command behave more like with "help"
  • Also pass remote node info for regular help commands
  • Apply node name normalization in cli when loading available commands
  • mix format
  • Inline secondary umbrella archive handling
  • Use 3.10.12 for mixed version testing
  • Build the mixed version artifact with erlang 25.1
  • Report flow/blocked shovel status in Mgmt UI
  • Make CT helpers available for erlang_ls
  • Relax rabbit_auth_cache_SUITE:random_timing a bit
  • Update 3.11.5 release notes
  • Update 3.10.13 release notes
  • Use powershell as a backup to handle.exe
  • Execute powershell directly
  • Use win32_cmd/2 to run handle.exe because it is great.
  • Handle handle.exe output correctly
  • Resolve a conflict
  • Resolve a conflict in rabbit_mgmt_external_stats.erl
  • See Add HTTP API endpoint to retrieve effective configuration #6016. Add HTTP to fetch app environment config
  • Expose aten poll interval in rabbitmq.conf
  • Formatting of a newly introduced rabbit.schema setting
  • Add additional bazel flags to .bazelrc
  • Use ubuntu-20.04 in actions as the base OS
  • Fix default queue type handling for single vhost imports
  • Resolve a conflict
  • Remove unused rabbit_definitions:apply_defs/5
  • Resolve a conflict
  • See BAZEL: usage error improvement for test logs command #6645. Improving error output
  • Resolve a conflict
  • Update 3.11.5 release notes
  • Update 3.10.13 release notes
  • 3.9.27 release notes
  • Update mix_task_archve_deps to 1.0.0
  • Bump Ra to 2.4.5
  • Update 3.11.5 release notes
  • Update 3.10.13 release notes
  • Use direct exchange routing v1 for custom exchange types
  • Use more modern method to download definitions
  • Fix rules erlang version in WORKSPACE file
  • Adopt OTP 25.2
  • Delete function clauses that can never match
  • Resolve a conflict
  • Sync /workflows/update-otp-patches.yaml with main
  • Resolve a conflict
  • Remove redundant list_to_binary/1 call
  • Parse and apply default_policies.operator
  • Resolve a conflict
  • rabbit_feature_flags: Fix log message in rabbit_ff_controller
  • Use rules_erlang 3.8.5
  • Update //:test-logs and //:test-node-data
  • pin recon to cf5bfc290c6cdd46bea45ae4a6418e9802d511e5
  • See bazel: add rabbit-queues cmd to bazel, add default consumer_timeout to bazel (to match Make build default) #6703. Add rabbit-queues target
  • See bazel: add rabbit-queues cmd to bazel, add default consumer_timeout to bazel (to match Make build default) #6703. Add consumer_timeout default
  • Preserve heartbeat error reason
  • Don't crash listing listeners when a node is shutting down
  • Adopt elixir 1.13.4
  • Adopt otp 25.0.4
  • Adopt otp 25.1.2
  • Adopt otp 25.2
  • Bump actions/cache from 3.0.11 to 3.2.0
  • Ra 2.4.6
  • Bazel 6 compatibility
  • Resolve a conflict
  • Link to Bazel guide in CONTRIBUTING.md
  • Check if stream coordinator is quorum critial
  • Make a test less flaky; formatting
  • Bump actions/cache from 3.2.0 to 3.2.1
  • Pin to recon 2.5.3
  • Bump actions/cache from 3.2.1 to 3.2.2
  • Escape the user controlled error parameter
  • Merge pull request (c) year bump: 2022 => 2023 #6783 from rabbitmq/mk-c-year-2023
  • Cosmetics
  • Support Idp initiated logon in mgt ui with Oauth
  • Support path_prefix in /login url
  • Improve coverage
  • Test basic-auth behind proxy
  • Do not use cookies to store basic auth
  • Do not use cookies to store basic auth
  • Test with selenium export/import definitions
  • Use only token in authorization header to
  • Fix import/export test cases
  • Rename section otherwise
  • Refactor code following recommendations
  • Test token refresh
  • Validate imported user from file
  • Run selenium GH Action on oidc_idp_initiated_login branch
  • Remove branch
  • Resolve conflict
  • Merge branch 'iliakur-ik/link-detailed-endpoint-docs-to-website'
  • Resolve conflicts related to OAuth 2.0: support IDP-initiated login in the management UI #6015
  • Sync .github/workflows/test-selenium.yaml with main
  • Format stream plugin code
  • Filter out nodes in maintenance in stream metadata
  • Remove console output
  • DRY: Link docs for /metrics/detailed endpoint to website.
  • Update metrics-detailed.md
  • Resolve conflicts
  • Make classic queues v2 memory efficient
  • Test Unicode char in queue names
  • Resolve conflicts
  • Fix failing unicode_SUITE
  • 3.10.14 release notes
  • 3.11.6 release notes
  • Merge pull request add affiliation for Patrik (dentarg) #6809 from johanrhodin/patch-9
  • Bump actions/upload-artifact from 3.1.1 to 3.1.2
  • Add load_definitions example
  • Bump actions/cache from 3.2.2 to 3.2.3
  • rabbit_feature_flags: Sync enabled feature flags differently on virgin node
  • rabbit_feature_flags: Support virgin node init with feature flags v2
  • rabbit_feature_flags: Export rabbit_ff_controller functions for internal use
  • format with buildifier
  • Add "bazel run //tools:symlink_deps_for_erlang_ls"
  • Make erlang_ls links a bit more stable
  • Remove unused rule
  • Remove 'w' option from ln call in //tools:symlink_deps_for_erlang_ls
  • rabbit_feature_flags: Fix {enable,post_enable}_callback() type spec
  • rabbit_feature_flags: Remove incorrect paragraph in enable_callback() doc
  • Fix connection linger for WebSTOMP
  • Fix tests: Do not close connection from client side
  • Adopt otp 25.1.2
  • Adopt elixir 1.13.4
  • Adopt otp 25.2
  • Adopt otp 25.0.4
  • Fix migration for direct_exchange_routing_v2
  • rabbit_feature_flags: Restore feature flag state if we fail to enable it
  • rabbit_feature_flags: Use erpc:call/5 to properly catch exceptions
  • Handle the body is undefined
  • Update prometheus.erl to 4.10.0
  • Conform vhost tags to a list when set with the cli in all cases
  • Correct the default for vhost:get_tags/1 to match the spec
  • Fix all dialyzer warnings in rabbitmq_prometheus
  • Resolve a conflict
  • Fix all dialyzer warnings in amqp_client
  • Resolve a conflict
  • Update 3.10.14 release notes
  • 3.9.28 release notes
  • 3.11.7 release notes
  • Fix all dialyzer warnings in rabbitmq_federation
  • Fix all dialyzer warnings in rabbitmq_stream
  • Fix conflict
  • Resolve conflicts
  • diagnostics check_port_connectivity: support --address
  • CLI: mix format
  • Update tests
  • Add Dead lettering en masse can overload the DLQ #5312 to 3.10.14 release notes
  • Add Dead lettering en masse can overload the DLQ #5312 to 3.11.4 release notes
  • Fix all dialyzer warnings in rabbitmq_amqp1_0
  • Correct a copy-paste artifact in 3.11.7 release notes
  • Resolve conflicts
  • rules_erlang 3.9.0 compatibility
  • Adopt otp 25.2.1
  • Streams: Move nopush to reader to try to combine small chunks into larger IP packets.
  • Simplify BUILD files by using new macros from rules_erlang 3.9.0 (backport Simplify BUILD files by using new macros from rules_erlang 3.9.0 #6928) (Simplify BUILD files by using new macros from rules_erlang 3.9.0 (backport #6928) #6934)
  • rabbit: Add is_serving/{0,1} function
  • Fix all dialyzer warnings in rabbitmq_management_agent
  • Fix all dialyzer warnings in rabbitmq_web_dispatch
  • Fix all dialyzer warnings in rabbitmq_management
  • Resolve a conflcit
  • Resolve conflicts
  • Adopt otp 25.1.2.1
  • Fix all dialyzer warnings in auth backends
  • Fix another dialyzer warning
  • Fix all dialyzer warnings in rabbitmq_sharding
  • Fix all dialyzer warnings in rabbitmq_web_mqtt
  • Resolve a conflict
  • Change alias to test_suite in deps/rabbitmq_cli/BUILD.bazel
  • Fix all dialyzer warnings in rabbitmq_recent_history_exchange
  • Fix incorrect default value for exchange subscription
  • Fix all dialyzer warnings in AWS-related plugins
  • Resolve conflicts
  • Update rabbitmq_peer_discovery_aws.yaml
  • Update rabbitmq_peer_discovery_aws.yaml
  • Rework plt/dialyze for rabbitmqctl and plugins that depend on it
  • Fix dialyzer warnings revealed from previous commit
  • Fixup docstring
  • Quote vars in shell in deps/rabbitmq_cli/rabbitmqctl.bzl
  • Secondary umbrella: bump to 3.10.14
  • Update etcd testing version
  • Bump node versions for selenium tests
  • Fix all dialyzer warnings in peer discovery plugins
  • Fix all dialyzer warnings in rabbitmq_jms_topic_exchange
  • See Add command and HTTP API to hash a value according to our algorithm #5957. CLI command to generate hashed password from cleartext password
  • See Add command and HTTP API to hash a value according to our algorithm #5957. HTTP api to generate hashed password from cleartext password
  • Resolve conflict
  • Update the image reference in the AWS integration suite
  • Fix all dialyzer warnings in rabbit
  • Fix 3.11-specific dialyzer warnings in rabbit

binarin and others added 30 commits December 12, 2022 15:47
Default queue type logic didn't apply when import was done for a
single vhost. Exported definitions for a single vhost don't contain
`vhost` key, and anyway it's better to use the actual vhost name that
will be used for queue declaration.

And just in case, `vhost` is now stripped from all exported items for
a single vhost (it was still present in `parameters` and `policies`) -
on import it was ignored, but it could have been a source of the bug
similar to the one with the default queue type.

(cherry picked from commit 4bfe352)

# Conflicts:
#	deps/rabbit/src/rabbit_definitions.erl
Fix default queue type handling for single vhost imports (backport #6599)
`rabbit_definitions:apply_defs/5` contains a bug
where it was trying to import bindings too
early (https://github.com/rabbitmq/rabbitmq-server/blob/aec3dcbf37ac9f6cecf9f4c6bde7a49c4f045857/deps/rabbit/src/rabbit_definitions.erl#L480).
`apply_defs/4` imports exchanges at exactly the same place.

Turns out `apply_defs/5` is almost an verbatim copy of
`apply_defs/4`, just with custom error handling - and it isn't being
used anywhere in the source code.

Also removes related unused exports.

(cherry picked from commit aa0104c)

# Conflicts:
#	deps/rabbit/src/rabbit_definitions.erl
Remove unused rabbit_definitions:apply_defs/5 (backport #6638)
(cherry picked from commit 20b2352)

# Conflicts:
#	BUILD.bazel
Improve error output of `bazel run test-logs` (backport #6646)
(cherry picked from commit 9d8bb17)
(cherry picked from commit ba71c2a)
(cherry picked from commit b8ade09)
Also update with SHA512 so that the download and install via `mix archive.install` works.

Related to: https://groups.google.com/g/rabbitmq-users/c/mSJMjyE20Nk

(cherry picked from commit cedf909)
Update mix_task_archve_deps to 1.0.0 (backport #6652)
(cherry picked from commit 3d38483)
(cherry picked from commit 8b96b4e)
(cherry picked from commit cc28dba)
Custom exchange types can use the direct exchange as a proxy for
routing. However, custom exchange types should continue to use "direct
exchange routing v1" because their bindings are not inserted into the
new routing table `rabbit_index_route`.

This commits avoids changing the custom exchange types to call
`rabbit_router:match_routing_key/2` directly as done in
rabbitmq/rabbitmq-delayed-message-exchange#200
and
rabbitmq/rabbitmq-lvc-exchange#32
because other exchange types are out there (as we learnt in
#4606 (comment))
which also need to continue to use v1.

So, the cleaner approach is to only use direct exchange routing v2 if
1. the feature flag 'direct_exchange_routing_v2' is enabled, and
2. the source exchange is of type 'direct'

(cherry picked from commit a25eeb0)
Use direct exchange routing v1 for custom exchange types (backport #6658)
Does not require sending auth as a query parameter

Ref: https://vmware.slack.com/archives/C0RDGG81Z/p1669827808015729
(cherry picked from commit a193f45)
Use more modern method to download definitions (backport #6674)
it did not match MODULE.bazel as it should
(cherry picked from commit d78b8b3)

# Conflicts:
#	.github/workflows/update-otp-patches.yaml
(cherry picked from commit 04de0c7)

# Conflicts:
#	deps/rabbitmq_peer_discovery_common/src/rabbit_peer_discovery_httpc.erl
pjk25 and others added 27 commits January 20, 2023 16:18
Fix the cross-workflow reference to the oci workflow

(cherry picked from commit 40a3cac)
Update rabbitmq_peer_discovery_aws.yaml (backport #6982)
Another attempt at #6982

(cherry picked from commit a29afa3)
Update rabbitmq_peer_discovery_aws.yaml (backport #6985)
This allows us to stop ignorning undefined callback warnings

When mix compiles rabbitmqctl, it produces a 'consolidated' directory
alongside the 'ebin' dir. Some of the modules in consolidated are
intended to be used instead of those provided by elixir. We now handle
the conflicts properly in the bazel build.

(cherry picked from commit b84e746)
(cherry picked from commit 057f776)
Also ensure init script passes `shellcheck`

Updated while looking into #5792

(cherry picked from commit 7ac6fea)
Search for `Error: Cannot find module 'node:events'` in internet
suggests using at least node 16.6.

(cherry picked from commit 6517c7f)
(cherry picked from commit 183a260)

# Conflicts:
#	deps/rabbitmq_peer_discovery_consul/src/rabbit_peer_discovery_consul.erl
#	deps/rabbitmq_peer_discovery_etcd/src/rabbitmq_peer_discovery_etcd_v3_client.erl
#	deps/rabbitmq_peer_discovery_k8s/src/rabbitmq_peer_discovery_k8s_node_monitor.erl
See #5957. CLI cmd to generate hashed password from cleartext password (backport #7003)
Update the image reference in the AWS integration suite (backport #7016)
@binarin binarin closed this Jan 24, 2023
@mergify
Copy link

mergify bot commented Jan 24, 2023

⚠️ The sha of the head commit of this PR conflicts with #7025. Mergify cannot evaluate rules on this PR. ⚠️

@michaelklishin michaelklishin deleted the dialyzer-warnings-rabbit-v3.11.x branch January 24, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet