Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose aten poll interval in rabbitmq.conf #6632

Merged
merged 2 commits into from Dec 12, 2022

Conversation

michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented Dec 12, 2022

Proposed Changes

as raft.adaptive_failure_detector.poll_interval.

On systems under peak load, inter-node communication link congestion can result in false positives and trigger QQ leader re-elections that are unnecessary and could make the situation worse.

Using a higher poll interval would at least reduce the probability of false positives.

Per discussion with @kjnilsson @mkuratczyk.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

The doc part of this change is TBD.

as `raft.adaptive_failure_detector.poll_interval`.

On systems under peak load, inter-node communication link congestion
can result in false positives and trigger QQ leader re-elections that
are unnecessary and could make the situation worse.

Using a higher poll interval would at least reduce the probability of
false positives.

Per discussion with @kjnilsson @mkuratczyk.
@michaelklishin michaelklishin merged commit aec3dcb into main Dec 12, 2022
@michaelklishin michaelklishin deleted the mk-aten-poll-interval-in-rabbitmq.conf branch December 12, 2022 13:05
michaelklishin added a commit that referenced this pull request Dec 12, 2022
Expose aten poll interval in rabbitmq.conf (backport #6632) (backport #6633)
michaelklishin added a commit that referenced this pull request Dec 12, 2022
Expose aten poll interval in rabbitmq.conf (backport #6632) (backport #6633) (backport #6636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant