Don't crash listing listeners when a node is shutting down (backport #6719) #6721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Previously a management api request could crash as below while the overview
page was open during a node restart.
```
crasher:
initial call: cowboy_stream_h:request_process/3
pid: <0.1902.0>
registered_name: []
exception error: bad argument
in operator ++/2
called as {badrpc,
{'EXIT',
{badarg,
[{ets,match_object,
[rabbit_listener_ets,'_'],
[{error_info,
#{cause => id,module => erl_stdlib_errors}}]},
{ets,tab2list,1,[{file,"ets.erl"},{line,771}]}]}}}
++
[{listener,'rabbit@<hostname>',http,
"<hostname>",
{0,0,0,0,0,0,0,0},
15672,
[{cowboy_opts,[{sendfile,false}]},
{ip,"0.0.0.0"},
{port,15672},
{ssl,false}]},
...
in call from lists:append/1 (lists.erl, line 155)
in call from rabbit_mgmt_wm_overview:listeners/0 (rabbit_mgmt_wm_overview.erl, line 111)
in call from rabbit_mgmt_wm_overview:to_json/2 (rabbit_mgmt_wm_overview.erl, line 66)
in call from cowboy_rest:call/3 (src/cowboy_rest.erl, line 1575)
in call from cowboy_rest:set_resp_body/2 (src/cowboy_rest.erl, line 1464)
in call from cowboy_rest:upgrade/4 (src/cowboy_rest.erl, line 284)
in call from cowboy_stream_h:execute/3 (src/cowboy_stream_h.erl, line 300)
```
(cherry picked from commit d42f7c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #6719 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com