Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty channel detail format in management api #7040

Merged
merged 1 commit into from Jan 26, 2023
Merged

Fix empty channel detail format in management api #7040

merged 1 commit into from Jan 26, 2023

Conversation

Syuparn
Copy link
Contributor

@Syuparn Syuparn commented Jan 25, 2023

Proposed Changes

This fixes the response body format of management API GET /api/queues/%2f/{queuename}. While a channel is being deleted, the API returns an empty object as field .consumer_details[].channel_details so that SDK deserializers can handle this.

Close: #2684

# empty channel_detail is formatted as empty object
$ curl -s http://guest:guest@localhost:15672/api/queues/%2f/queue1 | jq .consumer_details[].channel_details
{
  "connection_name": "172.28.0.1:33550 -> 172.28.0.2:5672",
  "name": "172.28.0.1:33550 -> 172.28.0.2:5672 (1)",
  "node": "rabbit@d088896b1c04",
  "number": 1,
  "peer_host": "172.28.0.1",
  "peer_port": 33550,
  "user": "guest"
}
{}

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue Inconsistent type for channel_details when requesting queue admin data #2684)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

The response body above is checked by local Docker image bazel/packaging/docker-image:rabbitmq.

Signed-off-by: syuparn <s.hello.spagetti@gmail.com>
@michaelklishin
Copy link
Member

@Syuparn thank you 🙏

@Syuparn Syuparn deleted the rabbitmq-server-2684 branch January 26, 2023 03:11
michaelklishin added a commit that referenced this pull request Jan 26, 2023
Fix empty channel detail format in management api (backport #7040)
michaelklishin added a commit that referenced this pull request Jan 26, 2023
Fix empty channel detail format in management api (backport #7040) (backport #7041)
michaelklishin added a commit that referenced this pull request Jan 26, 2023
Fix empty channel detail format in management api (backport #7040) (backport #7041) (backport #7047)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent type for channel_details when requesting queue admin data
2 participants