Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the rabbitmq_auth_backend_oauth2 schema #7190

Merged
merged 1 commit into from Feb 6, 2023

Conversation

brunomedeirosdedalus
Copy link
Contributor

@brunomedeirosdedalus brunomedeirosdedalus commented Feb 4, 2023

Fixing reference to the old key 'additional_rabbitmq_scopes'. Removing redundant mapping

Proposed Changes

I am unable to make use of the key 'additional_scopes_key'; It seems to me that is a bug caused by the redundant mapping.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

Fixing reference to the old key 'additional_rabbitmq_scopes'. Removing redundant mapping
@pivotal-cla
Copy link

@brunomedeirosdedalus Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@brunomedeirosdedalus Thank you for signing the Contributor License Agreement!

@michaelklishin
Copy link
Member

The second mapping introduced in #6015, possibly as a merge/rebase artifact.

@michaelklishin michaelklishin merged commit 3b5ec6a into rabbitmq:main Feb 6, 2023
@michaelklishin
Copy link
Member

@MarcialRosales FYI. We need to backport this to v3.10.x when it is time to backport #6015 to that branch.

michaelklishin added a commit that referenced this pull request Feb 6, 2023
Fixing the rabbitmq_auth_backend_oauth2 schema (backport #7190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants