Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return storage_version as top-level key in queue objects #9633

Merged
merged 2 commits into from Oct 10, 2023

Conversation

dcorbacho
Copy link
Contributor

A previous PR removed backing_queue_status as it is mostly unused, but classic queue version is still useful. This PR returns version as a top-level key in queue objects.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

A previous PR removed backing_queue_status as it is mostly unused,
but classic queue version is still useful. This PR returns version
as a top-level key in queue objects.
@dcorbacho dcorbacho added this to the 3.13.0 milestone Oct 4, 2023
@michaelklishin michaelklishin marked this pull request as ready for review October 10, 2023 19:03
@michaelklishin michaelklishin merged commit b100221 into main Oct 10, 2023
18 checks passed
@michaelklishin michaelklishin deleted the issue-9437-queue-storage-version branch October 10, 2023 23:44
dcorbacho added a commit that referenced this pull request Oct 16, 2023
dcorbacho added a commit that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants