-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
14 update getstate to return an array which could be extracted like react usestate #21
Conversation
rabisnaqvi
commented
May 25, 2023
- Updated the getState function to return an array similiar to how useState hook works
- Minor adjustment, instead of passing setState we are now passing a lister function instead.
- Updated unit tests to match the updated response from Astral.context.getState.
* Updated the getState function to return an array similiar to how useState hook works * Minor adjustment, instead of passing setState we are now passing a lister function instead.
…ct useState.#14 Updated unit tests to match the updated response from Astral.context.getState.
Pull Request Test Coverage Report for Build 5077901134
💛 - Coveralls |
@Siar416 thanks for contributing to this project! really appreciated. I have merged the changes after updating the unit tests etc ✨ |
@rabisnaqvi Thank you for giving me the opportunity to contribute to the project. I've given the project a star! Have you considered changing variables from "var" to "let" or "const"? Would be happy to start making those updates. |
@Siar416 Thankyou! About the scoped initializations, Yup actually I have planned to do that. I have created an issue (#15) to integrate babel or typescript into the project. once that is done we can use all the modern javascript features. but yes, you can start making those changes for now as most major browsers will support them. Also if you plan to start working on that, I thought that it would be good if we created pr for an internal feature branch rather than for the release-candidate. we could then merge the feature branch with the release candidate. |
Just to confirm, I could go ahead and change the variable that is "var" to
"let" and "const"? Those changes would then be merged into an internal
feature branch instead of release-candidate
…On Thu, May 25, 2023 at 11:00 AM Rabis Naqvi ***@***.***> wrote:
@Siar416 <https://github.com/Siar416> Thankyou!
About the scoped initializations, Yup actually I have planned to do that.
I have created an issue (#15
<#15>) to integrate babel
or typescript into the project. once that is done we can use all the modern
javascript features. but yes, you can start making those changes for now as
most major browsers will support them.
Also if you plan to start working on that, I thought that it would be good
if we created pr for an internal feature branch rather than for the
release-candidate. we could then merge the feature branch with the release
candidate.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT5HNDDCN7R6E6KLFXS5PCLXH5XYTANCNFSM6AAAAAAYOQCAHM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yup, that is correct! I have created an internal branch (15-integrate-typescript-or-babel), when you want, you can create a pull request to this internal branch rather than release-candidate. |
Awesome! I'll start working on that once I get a chance. Either later today
or tomorrow.
…On Thu, May 25, 2023 at 11:20 AM Rabis Naqvi ***@***.***> wrote:
Yup, that is correct! I have created an internal branch
(15-integrate-typescript-or-babel), when you want, you can create a pull
request to this internal branch rather than release-candidate.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT5HNDAOF7XLM5DKIQDM46LXH52E7ANCNFSM6AAAAAAYOQCAHM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|