Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Typescript or babel #15

Closed
2 of 4 tasks
rabisnaqvi opened this issue May 24, 2023 · 1 comment
Closed
2 of 4 tasks

Integrate Typescript or babel #15

rabisnaqvi opened this issue May 24, 2023 · 1 comment
Assignees
@rabisnaqvi
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@rabisnaqvi
Copy link
Owner

rabisnaqvi commented May 24, 2023 •
edited

Currently, we do use ES6 modules but we are not parsing the build to support legacy browsers. We should integrate TypeScript and use that as a webpack module.

Tasks for this issue:

  • Convert the application into TypeScript supported format
  • Create TypeScript interfaces for each data type
  • Convert all unit tests and specs into TypeScript
  • Make sure that TypeScript polyfills are only added to the build once, and not in each module.
@rabisnaqvi rabisnaqvi added the enhancement New feature or request label May 24, 2023
@rabisnaqvi rabisnaqvi self-assigned this May 24, 2023
@rabisnaqvi rabisnaqvi added help wanted Extra attention is needed question Further information is requested labels May 24, 2023
@rabisnaqvi rabisnaqvi mentioned this issue May 25, 2023
Merged
@rabisnaqvi rabisnaqvi removed their assignment May 26, 2023
@rabisnaqvi rabisnaqvi self-assigned this May 26, 2023
@rabisnaqvi rabisnaqvi mentioned this issue May 26, 2023
Merged
rabisnaqvi added a commit that referenced this issue May 26, 2023
@rabisnaqvi @Siar416 @Hasrivastav
🐲 Release 1.2.0 (#31)
9933c94 
- 🤯 Updated the getState function to return an array (tuple) similar to how React's useState hook works (#14 )
- ✅ Updated unit tests to match the updated response from Astral.context.getState.
- 📃 Fix broken hyperlink in the Getting Started section (#26 )
  - Replaced the broken hyperlink reference with the correct anchor link to the "Core Concepts" section.
  - Ensured that the anchor link matches the heading in the "Core Concepts" section.
- 🌀 Integrate Typescript or babel (#15 )
  - Converted all the source files to TypeScript namespaces.
  - Updated build process to parse the javascript files.
  - Replaced JSDOC with TypeDoc to generate documentation for the new typescript codebase.
  - Updated ESLINT configuration to be integrated with TypeScript.
  - Added some unit tests.
- 📃Break features and definitions into different lines in readme (#24 )
  - Updated readme.md to fix the line breaks and to reflect new updated features in Astral.context.getState and Astral.context.updateState.
- 📃Updated CONTRIBUTING.md
  - Updated CONTRIBUTING.md to ensure updated contributing processes.

---------


Co-authored-by: Rabis Naqvi <rabis.naqvi@xynotech.com>
Co-authored-by: Siar <83523212+Siar416@users.noreply.github.com>
Co-authored-by: HARSH SRIVASTAV <96014384+Hasrivastav@users.noreply.github.com>
@rabisnaqvi
Copy link
Owner Author

For now, what we have done is enough. So closing this ticket, the work is released with #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rabisnaqvi rabisnaqvi

Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
Astral.js Main Development Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rabisnaqvi