Xinerama crashing bug on non-xinerama screens #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a possibility of a null pointer returned by XRRGetScreenResources in mod_xrandr_get_outputs_for_geom. It wasn't getting checked. Now it is.
raboof
changed the title
raboof
approved these changes
Jun 7, 2020
|
Fixes #288 |
|
I don't know tbh... I certainly don't have enough experience with this codebase to be able have an opinion on preemptive protections, it wasn't crashing out on me |
Well, given that we now know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a possibility of a null pointer returned by
XRRGetScreenResources in mod_xrandr_get_outputs_for_geom. It wasn't
getting checked. Now it is.