Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign-On-O-Tron support #214

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

rlafferty05
Copy link

  • Added support for the Sign-On-O-Tron oauth2 provider. Information about it can be found here.
  • Changed the javascript require to use httpswwwroot because the buttons weren't showing up on https login pages.

@mouneyrac
Copy link
Collaborator

mouneyrac commented Sep 17, 2016

Hi Ryan,
thanks for the pull request. How do I test it? Where do I find a Sign-On-O-Tron provider?

@rlafferty05
Copy link
Author

Hi Jerome,
Sorry for the delay on getting back to you. If you can give me an email address we can set up an account for you to test it on the site I developed it for.

@mouneyrac
Copy link
Collaborator

Thanks Ryan, it seems like a good idea.

Otherwise where are the Sign-On-O-Tron docs? I know about nothing about this provider.

@rlafferty05
Copy link
Author

Hi Jerome,
The signonotron code and documentation are here: https://github.com/alphagov/signonotron2
I've also written the provider class: https://github.com/LearningPool/oauth2-signonotron

@rabser
Copy link
Owner

rabser commented Apr 20, 2017

Hi, i'm the new lead mantainer for this plugin and i'm going to release a new version, so i need to reconsider all the past merge requests.
In the new release i will update the phpleague client lib to the latest one: it seems that your code is ready for the 2.x release, but i need to double check everything before releasing and reading your past messages with Jerome, my email for enabling a testing account is sergio.rabellino@unito.it.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Version 3.0
May be implemented
Development

Successfully merging this pull request may close these issues.

None yet

3 participants