Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completion when company-mode is not available #112

Merged
merged 2 commits into from Dec 13, 2018
Merged

Fix completion when company-mode is not available #112

merged 2 commits into from Dec 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 4, 2018

:exit-function is actually not an company-mode specific thing. Other completion mechanisms may use it as well. The first commit disables it when company-mode is not installed.

The second commit adds an option to turn off this feature, because I saw this comment.

Thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 62.637% when pulling e4042c2 on zhangpj:fix-capf into bf8f76f on racer-rust:master.

Copy link
Collaborator

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kngwyu
Copy link
Collaborator

kngwyu commented Dec 5, 2018

Thanks!

@ghost
Copy link
Author

ghost commented Dec 12, 2018

I just found that this feature stopped working (with or without this patch). There might be some changes in company-mode.

I am investigating it. Please hold on.

@ghost
Copy link
Author

ghost commented Dec 12, 2018

That issue was fixed in company-mode: company-mode/company-mode@aabf0a3.

Do you mind merging this PR?

@kngwyu
Copy link
Collaborator

kngwyu commented Dec 13, 2018

Sorry I forgot to merge it...

@kngwyu kngwyu merged commit 7e1c016 into racer-rust:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants