Switch to asynchronous racer command with timeouts. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces blocking `call-process` with asynchronous `make-process`. Instead we block explicitly until racer process output is received or timeout fires. To that effect we introduce two new custom variables `racer-command-timeout` and `racer-eldoc-timeout`. The latter is important because Eldoc runs every time Emacs is idle but the user should be able to start typing any time without waiting on the racer process. Timeout value of nil will wait for the output indefinitely. I observed that the first time `racer` shell process runs it may take a while to respond probably due to indexing. Following responses tend to be snappy. For that reason and because user asking for completion is likely ok with a bit of waiting `racer-command-timeout` defaults to nil. `racer-eldoc-timeout` however should be fairly low. How low depends on your machine, etc. Value of 0.1 was too short on my machine, but 0.5 seems to work fairly reliably. Hopefully fixes racer-rust#97
1 similar comment
|
Thanks!
It's because racer calls
I think it's reasonable decision, though maybe I have to test it by actually using it. |
|
I tested in my repository and it looks everything works correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces blocking
call-processwith asynchronousmake-process.Instead we block explicitly until racer process output is received or timeout
fires. To that effect we introduce two new custom variables
racer-command-timeoutandracer-eldoc-timeout. The latter is important becauseEldoc runs every time Emacs is idle but the user should be able to start typing
any time without waiting on the racer process. Timeout value of nil will wait for
the output indefinitely.
I observed that the first time
racershell process runs it may take a while torespond probably due to indexing. Following responses tend to be snappy. For that
reason and because user asking for completion is likely ok with a bit of waiting
racer-command-timeoutdefaults to nil.racer-eldoc-timeouthowever should befairly low. How low depends on your machine, etc. Value of 0.1 was too short on my
machine, but 0.5 seems to work fairly reliably.
Hopefully fixes #97