fix!: remove incorrect and extra delimlen func (celestiaorg#809)

as noticed in
celestiaorg#804 (comment),
I forgot to delete the old `DelimLen` function after fixing a bug in
celestiaorg#747.

x/payment/types/payfordata.go

@@ -3,7 +3,6 @@ package types
 import (
 	"crypto/sha256"
 	"fmt"
-	"math/bits"
 
 	"github.com/celestiaorg/celestia-app/pkg/appconsts"
 	"github.com/celestiaorg/nmt"
@@ -232,8 +231,3 @@ func powerOf2(v uint64) bool {
 	}
 	return false
 }
-
-// DelimLen calculates the length of the delimiter for a given message size
-func DelimLen(x uint64) int {
-	return 8 - bits.LeadingZeros64(x)%8
-}

x/payment/types/payfordata_test.go

@@ -6,6 +6,7 @@ import (
 
 	sdkerrors "cosmossdk.io/errors"
 	"github.com/celestiaorg/celestia-app/pkg/appconsts"
+	shares "github.com/celestiaorg/celestia-app/pkg/shares"
 	"github.com/celestiaorg/nmt/namespace"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/stretchr/testify/assert"
@@ -421,7 +422,7 @@ func TestValidateBasic(t *testing.T) {
 // totalMsgSize subtracts the delimiter size from the desired total size. this
 // is useful for testing for messages that occupy exactly so many shares.
 func totalMsgSize(size int) int {
-	return size - DelimLen(uint64(size))
+	return size - shares.DelimLen(uint64(size))
 }
 
 func validWirePayForData(t *testing.T) *MsgWirePayForData {

x/payment/types/square_sizes.go

@@ -2,6 +2,7 @@ package types
 
 import (
 	"github.com/celestiaorg/celestia-app/pkg/appconsts"
+	shares "github.com/celestiaorg/celestia-app/pkg/shares"
 )
 
 // https://github.com/celestiaorg/celestia-app/issues/236
@@ -45,7 +46,7 @@ func AllSquareSizes(msgSize int) []uint64 {
 // It accounts for the necessary delimiter and potential padding.
 func MsgSharesUsed(msgSize int) int {
 	// add the delimiter to the message size
-	msgSize = DelimLen(uint64(msgSize)) + msgSize
+	msgSize = shares.DelimLen(uint64(msgSize)) + msgSize
 	shareCount := msgSize / appconsts.SparseShareContentSize
 	// increment the share count if the message overflows the last counted share
 	if msgSize%appconsts.SparseShareContentSize != 0 {