Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail instead of tmail in mailexceptions #42

Closed
wants to merge 2 commits into from
Closed

Conversation

bratke
Copy link

@bratke bratke commented Jul 14, 2011

Hi,

I migrated mailexceptions to require mail instead of tmail.
2 reasons:

  • tmail just did not seem to work on my setup (ruby 1.9.2, sinatra, 64-bit arch)
  • Mikel Lindsaar suggests this replacement (http://tmail.rubyforge.org/)
    I also fixed one failing test.

what i didn't:

  • gemspec is untouched

Regards,
L. Bratke

@ioquatix
Copy link
Member

This seems like a great patch... why hasn't it been integrated?

@rkh
Copy link
Member

rkh commented Oct 24, 2012

Because rack-contrib is currently not maintained.

@ioquatix
Copy link
Member

Okay so do you need a maintainer?

@rkh
Copy link
Member

rkh commented Oct 24, 2012

I guess so. You should talk to @rtomayko if you are interested.

@ioquatix
Copy link
Member

Okay, great, thanks @rkh.

@rtomayko I'm talking to you now it seems 🚁

@rkh
Copy link
Member

rkh commented Dec 10, 2012

If you rebase, I will merge.

@mpalmer
Copy link
Contributor

mpalmer commented Oct 31, 2014

Closing this PR in favour of #65, which appears to be a superset of this one.

@mpalmer mpalmer closed this Oct 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants