Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case where there is no existing cookie data #12

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

jeremyevans
Copy link
Contributor

In that case, use a blank session.

This requires modifying one spec, which had decode always called,
even if there was no cookie data.

The diff is best viewed ignoring whitespace.

Fixes #11

In that case, use a blank session.

This requires modifying one spec, which had decode always called,
even if there was no cookie data.

Fixes rack#11
Copy link
Member

@ioquatix ioquatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ioquatix ioquatix merged commit 8a4a5f3 into rack:main Aug 11, 2022
@AlexWayfer
Copy link

Release this please.

@ioquatix ioquatix added this to the v0.3.0 milestone Sep 24, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError: undefined method `rpartition' for nil:NilClass
3 participants