Rack 1.5: Use equal? to compare form_input to rack.input #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using equal? provides consistent results of equality between 1.8, 1.9, and 2.0 when comparing Tempfile objects. In 1.8, == will change the position of the Tempfile. In 1.9+, == compares Tempfiles correctly. In 1.8, eql? compares Tempfiles correctly In 1.9+, t.eql?(t) always returns false
filipegiusti
referenced
this pull request
Nov 13, 2014
Using equal? provides consistent results of equality between 1.8, 1.9, and 2.0 when comparing Tempfile objects. In 1.8, == will change the position of the Tempfile. In 1.9+, == compares Tempfiles correctly. In 1.8, eql? compares Tempfiles correctly In 1.9+, t.eql?(t) always returns false
spastorino
added a commit
that referenced
this pull request
Nov 14, 2014
Rack 1.5: Use equal? to compare form_input to rack.input
dblock
added a commit
to ruby-grape/grape
that referenced
this pull request
May 7, 2015
This was referenced May 7, 2015
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to rack 1.5 of #588 by @statianzo
It's really just a cherry-pick without changes. But that's all I can do to make this be merged faster on rack 1.5.