Remove Rack::HTTP_VERSION and don't set HTTP_VERSION in env in cgi and webrick #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenderlove
approved these changes
Jul 14, 2020
|
Excellent. |
lloeki
added a commit
to lloeki/thin
that referenced
this pull request
Jan 2, 2024
This spec failed:
Thin::Request parser should not fuck up on stupid fucked IE6 headers
with:
should validate with Rack Lint: env[HTTP_VERSION] does not equal env[SERVER_PROTOCOL]
where:
"HTTP_VERSION"=>"HTTP/1.0",
"SERVER_PROTOCOL"=>"HTTP/1.1",
Indeed:
> Rack::HTTP_VERSION has been removed and the HTTP_VERSION env setting is no longer set in the CGI and Webrick handlers
See:
- rack/rack#970
- rack/rack#969
- rack/rack#1691
The version is necessary to negotiate `persistent?`, so here we punt on
a further refactoring to find a good way to get the request HTTP version
from the first line, instead shoving it in a Thin-specific
`thin.request_http_header`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #970