Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringify the keys in SessionHash#merge #428

Closed
wants to merge 1 commit into from
Closed

Stringify the keys in SessionHash#merge #428

wants to merge 1 commit into from

Conversation

leifg
Copy link

@leifg leifg commented Sep 5, 2012

As mentioned in #427 the merge! method does not take care of stringifying the keys. That leads to errors if you add symbol (or other non-string) keys as the values will never be read as the fetch converts everything to a string:

def [](key)
    load_for_read!
    super(key.to_s)
end

@travisbot
Copy link

This pull request passes (merged f0b47d0 into ea7ed1a).

@raggi
Copy link
Member

raggi commented Nov 2, 2012

Apologies for not just merging, duped this change in 6b115c5, as i was looking at the issue not the PR. Avoid this by opening one :)

Thanks.

@raggi raggi closed this Nov 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants