Stringify the keys in SessionHash#merge #428

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

leifg commented Sep 5, 2012

As mentioned in #427 the merge! method does not take care of stringifying the keys. That leads to errors if you add symbol (or other non-string) keys as the values will never be read as the fetch converts everything to a string:

def [](key)
    load_for_read!
    super(key.to_s)
end

This pull request passes (merged f0b47d0 into ea7ed1a).

Owner

raggi commented Nov 2, 2012

Apologies for not just merging, duped this change in 6b115c5, as i was looking at the issue not the PR. Avoid this by opening one :)

Thanks.

raggi closed this Nov 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment