Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LINK and UNLINK methods to method override #575

Merged
merged 1 commit into from
Jun 15, 2013
Merged

add LINK and UNLINK methods to method override #575

merged 1 commit into from
Jun 15, 2013

Conversation

jamiehodge
Copy link
Contributor

Sinatra 1.4 onwards supports LINK and UNLINK. These methods are currently missing from the method override middleware. The spec currently says nothing about forms, but neither does it mention PUT and the like.

rkh added a commit that referenced this pull request Jun 15, 2013
add LINK and UNLINK methods to method override
@rkh rkh merged commit 2d1bc94 into rack:master Jun 15, 2013
@rkh
Copy link
Member

rkh commented Jun 15, 2013

I think we should also have Rack::Request#link? etc.

@jamiehodge
Copy link
Contributor Author

I went ahead and added #link? and #unlink? to Request

@rkh
Copy link
Member

rkh commented Jun 15, 2013

PR? :)

@jamiehodge
Copy link
Contributor Author

Why wasn't this commit pulled into this PR? (sorry, me-no-github apparently)

https://github.com/jamiehodge/rack/commit/a81b0f97b41d7d9370dceeff6d095a02a1b0ee1c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants