Handle mulipart requests with no part names #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
english
force-pushed
the
fix-multipart-noname
branch
from
0ef27d3
to
203fa3f
Compare
Previously, Rack would assume there would be either a Content-Disposition or Content-ID header for multipart request parts. This is not required in [rfc1341][0]. Now, Rack will use the Content-Type (falling back to text/plain) for the part name, storing parameters in an array, keyed off the content type. [0]: http://www.w3.org/Protocols/rfc1341/7_2_Multipart.html
english
force-pushed
the
fix-multipart-noname
branch
from
203fa3f
to
bc3aa3e
Compare
tenderlove
added a commit
that referenced
this pull request
Mar 5, 2015
Handle mulipart requests with no part names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a multipart request with no Content-Disposition or Content-ID headers for each part results in a
NoMethodError: undefined method 'force_encoding' for nil:NilClasserror atlib/rack/multipart/parser.rb:196.The following is a minimal request that reproduces the error:
Neither
Content-DispositionnorContent-IDare required headers for multipart request parts: rfc1341.The problem is that the
namefor the part isn't being assigned. I've chosen to assign it to theContent-Typeof the part (falling back totext/plainas per rfc1341), and then store this inparamas a list. This is the same strategy used in https://github.com/whostolebenfrog/compojure-multipart.