Freeze static strings in QueryParser#normalize_params #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why but trevis is broken on this command 😰 |
davydovanton
force-pushed
the
reduse-allocation
branch
from
bef203d
to
59b7242
Compare
| @@ -79,16 +80,16 @@ def normalize_params(params, name, v, depth) | |||
| raise RangeError if depth <= 0 | |||
|
|
|||
| name =~ %r(\A[\[\]]*([^\[\]]+)\]*) | |||
| k = $1 || '' | |||
| after = $' || '' | |||
| k = $1 || EMPTY_STRING | |||
davydovanton
force-pushed
the
reduse-allocation
branch
from
59b7242
to
329b850
Compare
matthewd
added a commit
that referenced
this pull request
Dec 23, 2015
Freeze static strings in QueryParser#normalize_params
|
Thanks for merge 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
stackprofandminitest/aroundgems for check all code calls in tests. And I found thatRack::QueryParser#normalize_paramshas big count of allocated object (figures below).Before
After