Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Racket on macOS Big Sur 11.1 or above #158

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Use Racket on macOS Big Sur 11.1 or above #158

merged 1 commit into from
Jun 19, 2021

Conversation

shhyou
Copy link
Contributor

@shhyou shhyou commented May 23, 2021

It's easier to point the students using Mac M1 to a fixed stable version such as 8.1 or 7.9. For this reason, mentioning the snapshot builds creates extra confusion when the particular build happens to contain other bugs.

As Racket works on Mac M1 with macOS 11.1 (or above) but not macOS 11.0, explain that the user may need to upgrade their OS.

@@ -118,7 +118,12 @@
@div[id: "m1_mac_explain"
style: note-style]{
@div{@b{M1 Mac users:}}
@list{Try a 64-bit ARM build from one of the @pre:installers{snapshot sites}.}}]
@list{
Try upgrade to macOS Big Sur 11.1 or above and select
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "upgrading"

@shhyou
Copy link
Contributor Author

shhyou commented May 23, 2021

Thanks! I also rearranged the sentence a little bit.

@rfindler
Copy link
Member

Here's a variant that tries to be softer about forcing them to upgrade their operating system.

The Mac OS (Intel 64-bit) variant works on macOS Big Sur 11.1 or above. 
If it crashes, consider upgrading your operating system.

Alternatively, newer versions of Racket support Apple Silicon directly.

Also, why are we pointing to the snapshot sites? I'm wondering if that's old text so I just changed it.

@mflatt
Copy link
Member

mflatt commented May 23, 2021

I agree that pointing to the snapshots is obsolete, and the suggested text to point to a later Racket version seems right.

@shhyou
Copy link
Contributor Author

shhyou commented May 23, 2021

Also, why are we pointing to the snapshot sites? I'm wondering if that's old text so I just changed it.

I think (but didn't check) when that paragraph was added, macOS 11.1 hasn't been released yet.

@rfindler
Copy link
Member

LGTM

download/download-pages.rkt Outdated Show resolved Hide resolved
@shhyou
Copy link
Contributor Author

shhyou commented May 24, 2021

Done! ("newer" -> "current")

I don't have opinion between "newer versions" and "the current version". But I don't understand the comment on 8.0. Are you thinking about HtDP?

@samth
Copy link
Sponsor Member

samth commented May 24, 2021

I'm trying to understand who this is for. Is this for someone going to download.racket-lang.org with an 11.0 M1 machine? Or for people who have been linked directly to a past download page? Or something else I'm failing to understand?

@sorawee
Copy link
Contributor

sorawee commented May 24, 2021

It's for a past download page. In particular, it appears on https://download.racket-lang.org/racket-v7.9.html, and only for version 7.9 (that is, e.g., https://download.racket-lang.org/racket-v7.8.html doesn't have this notice).

I think (equal? version version-before-m1-support) should be changed to (version<=? version version-before-m1-support) (or something like that) so that the warning about Big Sur 11.1 will appear to older versions as well.

I don't like the word "current version", because when users visit a page like https://download.racket-lang.org/racket-v7.9.html, the current version could mean the version the user is visiting. What about saying "8.0 or later"? Or even "latest version".

@rfindler
Copy link
Member

But I don't understand the comment on 8.0. Are you thinking about HtDP?

I'm not sure if this is directed at me, but if it is: I don't know! :) I'm happy with the changes.

@shhyou
Copy link
Contributor Author

shhyou commented May 24, 2021

I'm trying to understand who this is for. Is this for someone going to download.racket-lang.org with an 11.0 M1 machine? Or for people who have been linked directly to a past download page? Or something else I'm failing to understand?

For M1 users with macOS 11.0 using Racekt 7.9. In that case, the Intel 64-bit installation crashed, and the snapshot build gave this error.

the warning about Big Sur 11.1 will appear to older versions as well.

Makes sense.

Before adding the change, could anyone test if 7.8 and a few other versions work on 11.1 or above?

@samth
Copy link
Sponsor Member

samth commented May 24, 2021

If this is a warning only for the 7.9 page, then we should more strongly encourage downloading the latest version, I think.

@shhyou
Copy link
Contributor Author

shhyou commented May 24, 2021

How about this?

  • Shows the text block for all version <= 7.9
  • Points to the latest version first
  • Hints that the Intel variant needs Big Sur 11.1 or above

@mflatt mflatt merged commit b62a04e into racket:master Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants