Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] setting initial working directory for places #3965

Closed
samdphillips opened this issue Aug 18, 2021 · 2 comments
Closed

[Feature Request] setting initial working directory for places #3965

samdphillips opened this issue Aug 18, 2021 · 2 comments

Comments

@samdphillips
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When a parent place changes the current working directory it is not reflected in any subsequently started child places. Every child place has the same initial current working directory as when Racket was initially started.

Describe the solution you'd like
A keyword option for dynamic-place (and other place starting syntax) to set the current directory. The option should either default to the value of the (current-directory) parameter or the initial current working directory that Racket was started with (same as the current behavior.)

Describe alternatives you've considered
Places could explicitly negotiate (as part of their startup or as running operation) what the current directory could be set as. This requires developer effort.

Do you want to contribute to this feature
Maybe. I haven't read the place insides in while.

@mflatt
Copy link
Member

mflatt commented Aug 22, 2021

Let's try having a new place just inherit the creating place's directory. It's easy to imagine cases where you want that and difficult to imagine cases where you specifically don't want it.

It's also easy to imagine how a program might happen to work and get broken by the change to inherit current-directory. If the change doesn't cause test and pkg-build failures, though, then it seems like probably a good idea.

mflatt added a commit that referenced this issue Aug 22, 2021
Also, fix CS to inherit three other parameters whose values have long
been inherited in BC.

Related to #3965
@mflatt
Copy link
Member

mflatt commented Aug 26, 2021

So far, so good — no new pkg-build failures with the NWU snapshots.

@mflatt mflatt closed this as completed Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants