Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config-tethered installations ignore apps-dir #4079

Open
LiberalArtist opened this issue Dec 4, 2021 · 4 comments
Open

Config-tethered installations ignore apps-dir #4079

LiberalArtist opened this issue Dec 4, 2021 · 4 comments

Comments

@LiberalArtist
Copy link
Contributor

What version of Racket are you using?
Racket v8.3 [cs]

What program did you run?
I've put an example at https://gist.github.com/LiberalArtist/f96fa9fab28c9122631f0d3b1d4f9123.

What should have happened?
The drracket.desktop file should have been installed into the configured apps-dir.

Please include any other relevant details
I believe the apps-dir only applies on (non-Mac) Unix-like systems. I tried this on Kubuntu 21.10. The same issue affects Guix's racket package.

@mflatt
Copy link
Member

mflatt commented Jan 3, 2022

Currently, .desktop file creation is specifically skipped in tethering mode.

After refreshing my memory on how this all works, it looks like the consistent approach would be to add 'addon-tethered-app-dir and 'config-tethered-app-dir for use in a tethered setups. The latter could just be 'app-dir, since 'app-dir is otherwise unused in the same way that 'bin-dir and 'gui-bin-dir are not used for installation layering, but I'd be inclined to use 'config-tethered-app-dir for consistency.

Does that sound right to you?

mflatt added a commit that referenced this issue Jan 3, 2022
Support ".desktop" files in a tethered layer.

Addresses #4079
@mflatt
Copy link
Member

mflatt commented Jan 3, 2022

That idea seems to work out, at least in my experiments so far. I've pushed the change, partly with the idea that a round of snapshots will make it easier to try more experiments.

@LiberalArtist
Copy link
Contributor Author

This seems to work!

When I'd looked at this before, I vaguely remember having been unsure why 'app-dir had been handled differently than other keys. But adding 'config-tethered-app-dir analogously to the 'bin-dir case seems like a fine solution; at least, I can't remember any downside.

I will send a patch to Guix in the hope of getting more people to try 11ccee3 and ece8b17 before the 8.4 release.

@LiberalArtist
Copy link
Contributor Author

Submitted to Guix as https://issues.guix.gnu.org/53020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants