Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguous binding resulting from nested splicing-local in a definition context #4993

Closed
usaoc opened this issue May 14, 2024 · 0 comments · Fixed by #5000
Closed

Ambiguous binding resulting from nested splicing-local in a definition context #4993

usaoc opened this issue May 14, 2024 · 0 comments · Fixed by #5000

Comments

@usaoc
Copy link
Contributor

usaoc commented May 14, 2024

Reported by gregr on Discourse. A minimal program to reproduce the issue is

#lang racket/base
(require racket/splicing)

(splicing-local []
  (splicing-local [(define one 0)
                   (define (two) one)]
    3))

which triggers “one: identifier's binding is ambiguous”.
usaoc added a commit to usaoc/racket that referenced this issue May 23, 2024
@usaoc
more consistently apply 'definition-intended-as-local property
a5330ba 
Clean up `racket/splicing` to more consistently apply the
`'definition-intended-as-local` syntax property for every splicing
form through the `splicing-let-start/def` internal form, which
fixes racket#4993 and a similar bug for `splicing-letrec-syntaxes+values`.
In addition, fix multiple body forms in
`splicing-letrec-syntaxes+values`.

Add test cases for `splicing-letrec-syntaxes+values` and
`splicing-local` (which have different implementations than other
splicing forms), and update an old test case that did not test what it
was supposed to test.

Update the doc to index the `'definition-intended-as-local` syntax
property.
usaoc added a commit to usaoc/racket that referenced this issue May 23, 2024
@usaoc
more consistently apply 'definition-intended-as-local property
dbed8aa 
Clean up `racket/splicing` to more consistently apply the
`'definition-intended-as-local` syntax property for every splicing
form through the `splicing-let-start/def` internal form, which
fixes racket#4993 and a similar bug for `splicing-letrec-syntaxes+values`.
In addition, fix multiple body forms in
`splicing-letrec-syntaxes+values`.

Add test cases for `splicing-letrec-syntaxes+values` and
`splicing-local` (which have different implementations than other
splicing forms), and update an old test case that did not test what it
was supposed to test.

Update the doc to index the `'definition-intended-as-local` syntax
property.
@usaoc usaoc mentioned this issue May 23, 2024
Merged
3 tasks
usaoc added a commit to usaoc/racket that referenced this issue May 24, 2024
@usaoc
more consistently apply 'definition-intended-as-local property
baa0f05 
Clean up `racket/splicing` to more consistently apply the
`'definition-intended-as-local` syntax property for every splicing
form through the `splicing-let-start/def` internal form, which
fixes racket#4993 and a similar bug for `splicing-letrec-syntaxes+values`.
In addition, fix multiple body forms in
`splicing-letrec-syntaxes+values`.

Add test cases for `splicing-letrec-syntaxes+values` and
`splicing-local` (which have different implementations than other
splicing forms), and update an old test case that did not test what it
was supposed to test.

Update the doc to index the `'definition-intended-as-local` syntax
property.
mflatt pushed a commit that referenced this issue May 24, 2024
@usaoc @mflatt
more consistently apply 'definition-intended-as-local property
68676b3 
Clean up `racket/splicing` to more consistently apply the
`'definition-intended-as-local` syntax property for every splicing
form through the `splicing-let-start/def` internal form, which
fixes #4993 and a similar bug for `splicing-letrec-syntaxes+values`.
In addition, fix multiple body forms in
`splicing-letrec-syntaxes+values`.

Add test cases for `splicing-letrec-syntaxes+values` and
`splicing-local` (which have different implementations than other
splicing forms), and update an old test case that did not test what it
was supposed to test.

Update the doc to index the `'definition-intended-as-local` syntax
property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

more consistently apply 'definition-intended-as-local property usaoc/racket
1 participant
@usaoc