syntax/parse: Arrange for built-in macro’s names to be preserved #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dance that syntax/parse performs to lazily load its implementation rewrites uses of syntax/parse macros in such a way that their original names were discarded, which shows up in error messages. By simply invoking the underlying transformer directly in the proxy macro instead of expanding to a rewritten use, users’ names can be preserved. fixes racket#1909
lexi-lambda
force-pushed
the
gh-issue-1909
branch
from
758ddda
to
fb80d18
Compare
rmculpepper
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dance that syntax/parse performs to lazily load its implementation rewrites uses of syntax/parse macros in such a way that their original names were discarded, which shows up in error messages. This arranges for users’ names to be preserved.
fixes #1909