Simplify function definitions #3689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an automated change generated by [`resyntax`](https://github.com/jackfirth/resyntax). This change simplifies function definitions using shortcuts for `define` forms whose right-hand-side is either a lambda expression or a `case-lambda` expression equivalent to a function with a default argument.
samth
reviewed
Feb 17, 2021
| (cons (format " ~e" | ||
| (car args)) | ||
| (loop (cdr args))))))))))) | ||
| (define (((make-not-available id)) . args) |
There was a problem hiding this comment.
This might be less clear in the new version -- maybe 0-argument functions should be a special case?
There was a problem hiding this comment.
I think that makes sense. Opened jackfirth/resyntax#61 for this.
|
I could split it up into separate pull requests, would that be easier? |
|
I looked through all of the contract files and the changes seem good to me. I didn't check that the test suites still pass (although it seems very likely they would). If someone has it installed, running |
|
The contract tests run in the CI so we can see that they pass. |
|
Closing this pull request for a few reasons:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated change generated by
resyntax.This change simplifies function definitions using shortcuts for
defineforms whose right-hand-side is either a lambda expression or acase-lambdaexpression equivalent to a function with a default argument.