racket/src/{bc,cs/c}/configure fix arg stripping #3692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rktio doesn't know how to handle the --collectsdir argument and will stop the build process if it is passed to racket/src/configure, this fixes the immediate issue but the underlying issue remains and other unhandled arguments are likely to break rktio configure as well
|
Thanks for the patch! But I'll adjust the source of the configures scripts and rebuild them. The other argument that could cause problems in the same way is |
maueroats
pushed a commit
to maueroats/racket
that referenced
this pull request
Jun 17, 2021
Thanks to @tgbugs for the report an initial repair. Closes racket#3692
maueroats
pushed a commit
to maueroats/racket
that referenced
this pull request
Jun 17, 2021
Thanks to @tgbugs for the report an initial repair. Closes racket#3692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rktio doesn't know how to handle the --collectsdir argument and will
stop the build process if it is passed to racket/src/configure, this
fixes the immediate issue but the underlying issue remains and other
unhandled arguments are likely to break rktio configure as well