Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the type of sort #1008

Merged
merged 1 commit into from
Jan 8, 2021
Merged

fix the type of sort #1008

merged 1 commit into from
Jan 8, 2021

Conversation

capfredf
Copy link
Sponsor Member

No description provided.

@samth
Copy link
Sponsor Member

samth commented Dec 11, 2020

This looks right but the new test doesn't pass.

@jessealama
Copy link
Sponsor Contributor

I recently bumped into this false positive type checking (that is, type checking passed but it should have failed). If I make the change here to my local TR, I get the expected type check error.

@dannypsnl
Copy link
Contributor

I think this one failed because it raises two errors

Type Checker: Polymorphic function `sort' could not be applied to arguments:
...
Type Checker: Polymorphic function with keywords sort7 could not be applied to arguments:
...

a simple fix is changing to(exn-pred "Type Checker: Summary: 2 errors encountered"), but I have no idea if need to reduce to only report one error.

@samth
Copy link
Sponsor Member

samth commented Jan 7, 2021

It would be great to fix this before the release -- @capfredf do you want me to do that?

@capfredf
Copy link
Sponsor Member Author

capfredf commented Jan 7, 2021

Ah, I totally forgot this pending pull request. I will be working on those failed tests later today.

@capfredf capfredf merged commit 476a58a into racket:master Jan 8, 2021
samth added a commit to samth/graphics that referenced this pull request Jan 13, 2021
Typed Racket fixed the type of `sort` in racket/typed-racket#1008
which broke this code. The code was relying on a bug to typecheck.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants